-
Notifications
You must be signed in to change notification settings - Fork 6
Add logging statements all over the place #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
haha, these emojis😄 |
haha, yeah I like this a lot for debugging purposes as it helps me to visually filter the relevant statements. And the icons themselves are really not that important, just that they differ from one another. |
Is the old log file ever cleared? I just reloaded the window, (I thought the README says to reload the window - in order for the old logs to be removed?) |
The log management is taken care of by VSCode itself. When you reload the window, the old log file will have the same content. However, VSCode creates a new folder in a temporary directory with a fresh new log file. Just use the And yes, the Readme says to reload the window, such that VSCode is creating a new logfile for us. |
For me: What makes it open the NEW log file: |
So can you confirm the behavior is different than this? Note how the second log file resides in manim-logfiles.mp4 |
Yes, definitely different. The same log file opens. Here are these logs, you see the extension restarting:
Looks like this is another MacOS-related issue for us with @bhoov .. |
This can be moved to an issue as a bug, |
Yeah, as this PR is just adding simple log statements, fixes like these would be better suited for a subsequent one. Thanks for approving. |
In #56, we introduced a new logging mechanism. Here, we make use of that to log many important steps in the program, mainly for the
ManimShell
and the code preview. Note that as described in the Readme, the default logging level isInfo
, so adding thesedebug
ortrace
logging statements should not be a performance problem.I've also added a custom
Window
class that we can use (noteW
instead ofw
). Before showing the actual notification to the user, it will also log its message with respective log levels.