-
Notifications
You must be signed in to change notification settings - Fork 6
Add contributors to license file #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Certainly I will acknowledge your contributions in the License file. That said, I’d like to ensure that your significant impact on this extension is fully recognized. @Splines You have single-handedly contributed >90% of the functionality of this extension (by number of features implemented, bugs fixed, commits authored, etc.). I’d like to explore additional ways to credit you. Would you be interested in migrating this repository to your account, creating a joint organization where you’d be a co-owner, or transferring ownership of the marketplace extension to your account? I’m open to many options, if you are so inclined. What do you think would reflect your role appropriately? |
haha thanks for offering this ;) What do you think about transferring this repo to an organization? I've already done this with a project beforehand and it's really easy to do. We even managed to publish a pre-release version to PyPI and there I think it reads really nice when the organization itself is mentioned as release person. This way the branding would be more name-independent and I could be a co-owner as an example. This would also reduce turnaround times when I try to introduce a new branching strategy with Long-term, I'd really like to help maintaining this repo, but I will definitely not be able to invest as much time as I do right now in the initial building phase. Maybe just one or two hours in a week (or very long-term even less I'm afraid, just want to set expectations straight). I can imagine that this extension will gain significant traction in the community: I mean 3b1b's repo has almost 70k stars, so there will definitely be some users that will try out Manim Notebook and also report bugs. It'd be great to know that others like you might also tackle some of these bugs to slowly but steadily form this amazing project. And I plan to also use this extension on my own for some new YouTube videos. So I'm definitely interested that everything works as expected ;) With regards to crediting contributors: I think GitHub already does a good job in showcasing a |
let's not hurry too much with the release.. - |
(a bit unrelated to this PR, but ok... why not) Even though I agree on the idea of Rinse and Repeat:
I agree that I'd like to rather take a bit more time before the first "bigger" release to get the base functionality right without too obvious bugs that harm the workflow. We don't need all envisioned features in this first release, but those that we have should be nice to use right from the start. Otherwise, we risk users turning away from the extension and never coming back. And I can imagine that the wave of users trying out the extension will be bigger at the start now that 3b1b's video about his workflow is released. |
Perfect. Then let us not rush the advertisement of this extension and we'll do a release "the right way", with an organization and with major bugs fixed. Thank you both for your active work on this initial push. I too will not be able to maintain this for the super long term, but I hope we will find interest from the community to help maintain for the long term 🙏 |
@bhoov I just had the following idea: why not ask the ManimCommunity if we could transfer this repo to them? It's true that our extension is not for the Manim community version, but still: I feel like it'd be a good place to have this repo there as they bundle lots of Manim-related repositories. And having it there, it'd be probably also easier to find people to help/maintain in the long-term. And having it in the orga, I think it's still possible to assign specific people as "owners" of a repo. |
Probably does not change much legally-wise (see e.g. the first point of this answer). But still nice to recognize contributors in the license file.