Skip to content

Conversation

@jmcvey3
Copy link
Contributor

@jmcvey3 jmcvey3 commented Apr 30, 2025

Co-authored-by: ululi1970

Issue #390

Added a few Sentinel V specific code block readers. There are a few more in the documentation that I did not add (that are not in this test file), but I added "skip this many bytes" placeholders for if they're needed in the future.

Also did a little cleanup and changed two ambiguous attribute names to something more readable (hence a lot of test files changed), and I added a hard stop to exit the forever loop problem. It may cause some partly corrupted files that would otherwise be readable to fail, but we'll see.

@jmcvey3 jmcvey3 changed the title Initial fix for SentinelV Read Sentinel V specific data packets Apr 30, 2025
Copy link
Contributor

@ssolson ssolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcvey3 thanks for tackling this. Outside the use of magic numbers which seems inherent to reading the files and some docstrings that could be expanded this looks good. I'll wait a couple more days before merging to see if we get a response from OP on #390

@ssolson ssolson merged commit cde337f into MHKiT-Software:develop May 16, 2025
44 checks passed
@jmcvey3 jmcvey3 deleted the sentinelv branch June 27, 2025 15:22
akeeste pushed a commit to akeeste/MHKiT-Python that referenced this pull request Sep 30, 2025
Co-authored-by: ululi1970

Issue MHKiT-Software#390 

Added a few Sentinel V specific code block readers. There are a few more
in the documentation that I did not add (that are not in this test
file), but I added "skip this many bytes" placeholders for if they're
needed in the future.

Also did a little cleanup and changed two ambiguous attribute names to
something more readable (hence a lot of test files changed), and I added
a hard stop to exit the forever loop problem. It may cause some partly
corrupted files that would otherwise be readable to fail, but we'll see.
@akeeste akeeste mentioned this pull request Sep 30, 2025
akeeste added a commit that referenced this pull request Sep 30, 2025
v1.0.0
# MHKiT v1.0.0
## New Features
* Sound Exposure Level by @jmcvey3 in #388
* Add discharge function to MHKiT by @jmcvey3 in #385

## Functionality enhancements
* Fix for corrupted Nortek files by @jmcvey3 in #372
* Update integral length scale function by @jmcvey3 in #376
* Fix ever-changing RDI RiverPro depth bin ranges by @jmcvey3 in #378
* Allow clean functions to handle _avg variables by @jmcvey3 in #377
* IEC TS 62600 updates by @akeeste in #382
* MLER explanation updates/corrections by @rgcoe in #393
* Improve Nortek2 index file creator functions by @jmcvey3 in #397
* Read Sentinel V specific data packets by @jmcvey3 in #396
* Short list of VMDAS updates by @jmcvey3 in #405
* Allow user to specify universal Kolmogorov constant for TKE dissipation rate function by @jmcvey3 in #406
* Nortek Dual Profile Dataset Rotation by @jmcvey3 in #414

## Source code improvements
* Lint Tidal by @ssolson in #386
* Lint river module by @ssolson in #389
* Lint hindcast by @ssolson in #398
* Modernize Package Configuration by @ssolson in #400
* Configure specific warnings by @ssolson in #401

## Bug fixes
* Avoid failing to scan very large files by @jmcvey3 in #371
* Acoustics SPL bugfix by @jmcvey3 in #379
* DOLfYN/RDI: Set  `fs` to NaN when typical calculation methods yield error (#408) by @simmsa in #409

## Testing and Continuous Integration Updates
* Fix Jupyter Notebook tests running Python 3.13 by @ssolson in #380
* CI Test Clean Up: Mock USGS, Acoustic Tolerances by @ssolson in #404
* Speed up tests with concurrency checks to prevent duplicate workflows on PRs from develop into main or from main into develop by @akeeste
* Define MPLBACKEND to decrease intermittent matplotlib errors in tests by @akeeste

## Documentation and Examples
* Add WEC-Sim power performance example  by @akeeste in #395
* Update dolfyn function docstrings and associated notebooks by @jmcvey3 in #412
* Update examples by @akeeste in #417
* Update installation instructions in README.md by @akeeste
* Adjust acoustics test tolerances by @akeeste in #420

**Full Changelog**: v0.9.0...v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants