Skip to content

Fix for wave xarray conversion #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix for wave xarray conversion #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12937ee
restore correct default for pandas/xarray output
akeeste Apr 24, 2024
3141a31
update as_xarray flag to to_pandas in hindcast tests
akeeste Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mhkit/tests/wave/io/hindcast/test_hindcast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def test_multi_year(self):
parameters = "significant_wave_height"

wave_multiyear, meta = wave.io.hindcast.hindcast.request_wpto_point_data(
data_type, parameters, lat_lon, years, as_xarray=True
data_type, parameters, lat_lon, years, to_pandas=False
)
wave_multiyear_df = (
wave_multiyear["significant_wave_height_0"]
Expand Down
2 changes: 1 addition & 1 deletion mhkit/wave/io/hindcast/hindcast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def request_wpto_point_data(
str_decode=True,
hsds=True,
path=None,
to_pandas=False,
to_pandas=True,
):
"""
Returns data from the WPTO wave hindcast hosted on AWS at the
Expand Down