-
Notifications
You must be signed in to change notification settings - Fork 48
Fix wave elevation function. #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wave elevation function. #143
Conversation
|
@ssolson and @rpauly18 could you review this?
|
|
@cmichelenstrofer happy to review this. Are you still working on the fix for why the tests are failing, or would you like for me to look into this? |
|
@rpauly18 I just fixed the tests. You can go ahead and review it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Are you still working on more changes, or is this ready to be converted from a draft?
|
@rpauly18 just changed it from 'draft' to 'ready to review'. I deleted the two obsolete tests that I had commented out. |
|
Something wrong with the tests. They were passing before and nothing changed other than deleting comments. Seems the issue is not with this PR but with accessing some data at NREL needed for the tests. |
|
@cmichelenstrofer random failures happen sometimes because of the WPTO hindcast server being overloaded with request. I restarted the tests. If they fail again, I will investigate further. |
|
@rpauly18 can this be merged? |
Fixes #140. Fixes #142.