Skip to content

XML reader is skipping lines #147

@Matthew-Boyd

Description

@Matthew-Boyd

The XML reader '_xml_to_dataframe()' in noaa.py is skipping every other line of data as it is assuming every line is duplicated (indicated by the TODO statements on lines 146 and 154). This however is at least not the case for the test 'test_request_noaa_data()' in noaa.py. Therefore, half the data is being omitted in the output dataframe.

Specifically, the response from the noaa query includes data at times:
00:04
00:10
00:28
00:34
00:46
...

but the output from the XML reader only includes the times:
00:04
00:28
00:46
...

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions