Skip to content

Conversation

@abonnaudet-ledger
Copy link
Member

Description

Please provide a detailed description of what was done in this PR.
(And mention any links to an issue docs)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

Auto cherry-pick in API_LEVEL

If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:

[ ] TARGET_API_LEVEL: API_LEVEL_24
[ ] TARGET_API_LEVEL: API_LEVEL_25

This will only create the PR with cherry-picks, ready to be reviewed and merged.

Remember:

  • The merge will ALWAYS be a manual operation.
  • It is possible the cherry-picks don't apply correctly, mainly if previous commits have been forgotten.
  • In case of failure, there is no other solution than redo the operation manually...

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.41%. Comparing base (f7ad616) to head (10f8c5c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1283   +/-   ##
=======================================
  Coverage   62.41%   62.41%           
=======================================
  Files          14       14           
  Lines        1868     1868           
=======================================
  Hits         1166     1166           
  Misses        702      702           
Flag Coverage Δ
unittests 62.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abonnaudet-ledger abonnaudet-ledger force-pushed the abo_remove_get_mem_info_syscall branch from 0fc0a26 to 4c5e8a1 Compare October 23, 2025 16:05
@abonnaudet-ledger abonnaudet-ledger changed the title Remove get memory info syscall Remove os_get_memory_info syscall Oct 23, 2025
The `os_get_memory_info` was not used anymore.
@abonnaudet-ledger abonnaudet-ledger force-pushed the abo_remove_get_mem_info_syscall branch from 4c5e8a1 to 10f8c5c Compare October 28, 2025 08:53
Copy link
Contributor

@jarevalo-ledger jarevalo-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abonnaudet-ledger abonnaudet-ledger merged commit 94c8493 into master Oct 29, 2025
237 of 238 checks passed
@abonnaudet-ledger abonnaudet-ledger deleted the abo_remove_get_mem_info_syscall branch October 29, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants