Skip to content

fix: internal audit fixes #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 9, 2025
Merged

fix: internal audit fixes #1524

merged 8 commits into from
Jul 9, 2025

Conversation

ypatil12
Copy link
Collaborator

@ypatil12 ypatil12 commented Jul 9, 2025 •
edited
Loading

Motivation:

Updates for internal audit

Modifications:

  • byHash for ECDSA global registry
  • isRegistered -> isSpent for _globalKeyRegistry
  • Add docs for isOperatorSlashable on deregisterKey
  • In ECDSACertificateVerifier use uint256 for operatorIndex
  • Complete run on sentence in CertificateVerifier
  • Use BPS_DENOMINATOR in ECSDACV
  • Update documentation around no chainID for ECDSA domain separator
  • Fix ordering of functions in CertificateVerifier.md to match how they are documented
  • Update verifyCertificate return type in CertificateVerifier.md for ECDSA

Result:

Clearer docs/interfaces

@ypatil12 ypatil12 changed the title docs: typos feat: internal audit fixes Jul 9, 2025
@ypatil12 ypatil12 changed the title feat: internal audit fixes fix: internal audit fixes Jul 9, 2025
@ypatil12 ypatil12 merged commit 022f026 into main Jul 9, 2025
16 checks passed
@ypatil12 ypatil12 deleted the docs/typos branch July 9, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigenmikem eigenmikem eigenmikem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ypatil12 @eigenmikem