test: integration tests for op table calculator #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
approved these changes
Jun 5, 2025
| keyRegistrar.BN254_KEY_REGISTRATION_TYPEHASH(), address(this), operatorSet.avs, operatorSet.id, keccak256(bn254KeyBytes) | ||
| ) | ||
| ); | ||
| bytes32 messageHash = SignatureUtilsMixin(address(keyRegistrar)).domainSeparator(); |
There was a problem hiding this comment.
We can use the view function on keyRegistrar to get this?
8sunyuan
merged commit c757a4f
into
feat/operator-table-calculator
10 of 14 checks passed
8sunyuan
added a commit
that referenced
this pull request
Jun 5, 2025
<!--
🚨 ATTENTION! 🚨
This PR template is REQUIRED. PRs not following this format will be
closed without review.
Requirements:
- PR title must follow commit conventions:
https://www.conventionalcommits.org/en/v1.0.0/
- Label your PR with the correct type (e.g., 🐛 Bug, ✨ Enhancement, 🧪
Test, etc.)
- Provide clear and specific details in each section
-->
**Motivation:**
Testing for #1429
Updates Integration test framework for testing the
BN254OperatorTableCalculator
**Modifications:**
Contracts
- Updated `BN254TableCalculator` to have LOOKAHEAD_BLOCKS be immutable
Tests
- Updated Users (AVS.t.sol, User.t.sol)
- IntegrationBase
- `_newRandomAVS_WithBN254`
- `_newRandomAVS_WithECDSA`
- IntegrationDeployer, added multichain contracts although some are
missing pending feat PRs to be merged.
- ExistingDeploymentParser, added contract addresses
**Result:**
- Updated Integration test framework for testing the
BN254OperatorTableCalculator and other multichain flows
- fuzz tests for BN254OperatorTableCalculator in
`BN254OperatorSet_CalculateWeights.t.sol`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Testing for #1429
Updates Integration test framework for testing the BN254OperatorTableCalculator
Modifications:
Contracts
BN254TableCalculatorto have LOOKAHEAD_BLOCKS be immutableTests
_newRandomAVS_WithBN254_newRandomAVS_WithECDSAResult:
BN254OperatorSet_CalculateWeights.t.sol