feat: release escrow by strategy #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
force-pushed
the
feat/release-escrow-by-index
branch
from
71b7b58 to
ef7ecd5
Compare
ypatil12
changed the title
ypatil12
force-pushed
the
feat/release-escrow-by-index
branch
2 times, most recently
from
9cead91 to
8dcfd4e
Compare
0xClandestine
force-pushed
the
release-dev/redistribution
branch
from
7e82d53 to
d88ee4f
Compare
0xClandestine
force-pushed
the
feat/release-escrow-by-index
branch
from
9f6740d to
90b408f
Compare
0xClandestine
merged commit 94ad76c
into
release-dev/redistribution
27 of 39 checks passed
0xClandestine
added a commit
that referenced
this pull request
May 30, 2025
**Motivation:** We want to ensure: 1. We don't need a max strategy in operatorSet count 2. Blacklisted ERC-20 tokens do not block the escrow release of _other_ tokens **Modifications:** 1. Added a `releaseEscrowByStrategy` functionality, which takes in an strategy & releases that specific strategy 2. Added helper methods that both `releaseEscrow` and `releaseEscrowByStrategy` use 3. Cleaned up some latent DM POC changes **Result:** Handling all edge cases :) --------- Co-authored-by: clandestine.eth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to ensure:
Modifications:
releaseEscrowByStrategyfunctionality, which takes in an strategy & releases that specific strategyreleaseEscrowandreleaseEscrowByStrategyuseResult:
Handling all edge cases :)