docs: post-cantina doc updates #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📖 Documentation
ypatil12
force-pushed
the
yash/doc-updates
branch
from
81f4164 to
865dbb6
Compare
eigenmikem
approved these changes
Apr 2, 2025
ypatil12
force-pushed
the
yash/doc-updates
branch
from
db2d236 to
d8cfc55
Compare
bowenli86
pushed a commit
that referenced
this pull request
Apr 2, 2025
**Motivation:** Address doc updates from Cantina Audit. **Modifications:** - `deregisterFromOperatorSets` does not revert due to no try-catch - Permissionless Strategies added to audit report - We don't do `+1` on the `effectBlock` for allocations for instantaneous allocations - New deposits are immediately subject to slashing - Removing a strategy from an operatorSet does not allow a pending deallocation to be instantly completable - Completing a withdrawal as shares is OK even if the strategy is not on the whitelist - Delegating to operators with ultra-low magnitudes can result in loss of funds - Edge case regarding withdrawals for an operator blocked by owning negative shares & a fully slashed strategy - Negative rebase for strategies **Result:** More comprehensive docs. --------- Co-authored-by: Nadir Akhtar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Address doc updates from Cantina Audit.
Modifications:
deregisterFromOperatorSetsdoes not revert due to no try-catch+1on theeffectBlockfor allocations for instantaneous allocationsResult:
More comprehensive docs.