feat: v1.4.0 upgrade script #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📜 Script
ypatil12
force-pushed
the
yash/v1.4.0-testnet-holesky-upgrade-script
branch
from
ca8ac56 to
b9f6a4d
Compare
0xrajath
reviewed
Mar 18, 2025
0xrajath
reviewed
Mar 18, 2025
0xrajath
reviewed
Mar 18, 2025
0xrajath
reviewed
Mar 18, 2025
0xrajath
reviewed
Mar 18, 2025
0xrajath
previously approved these changes
Mar 18, 2025
8sunyuan
reviewed
Mar 18, 2025
| _permissionController: Env.proxy.permissionController(), | ||
| _DEALLOCATION_DELAY: Env.MIN_WITHDRAWAL_DELAY(), | ||
| _ALLOCATION_CONFIGURATION_DELAY: Env.ALLOCATION_CONFIGURATION_DELAY(), | ||
| _version: Env.deployVersion() |
There was a problem hiding this comment.
What zeus variable does this correspond to? Is it ZEUS_VERSION because that seems to be 1.3.1
There was a problem hiding this comment.
ZEUS_DEPLOY_TO_VERSION
8sunyuan
reviewed
Mar 18, 2025
| }); | ||
|
|
||
| deployImpl({ | ||
| name: type(AVSDirectory).name, |
There was a problem hiding this comment.
I'm assuming this is only changes with the SignatureUtilsMixin
There was a problem hiding this comment.
Yup - basically have to add versioning everywhere
8sunyuan
approved these changes
Mar 18, 2025
0xrajath
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need a script to upgrade preprod/testnet to
v1.4.0. This upgrade upgrades ALL core contracts, in order to bring versioning on-chain. It also encompasses our internal audit fixes.Core:
Pods:
Permissions:
Strategies
Modifications:
Adds
v1.4.0upgrade script. Similar to original upgrade script since we add versioning to all contracts.Removes
v1.2.0upgrade script.Result:
Completed deploy script