feat: ci storage check required #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
changed the title
ypatil12
approved these changes
Feb 3, 2025
ypatil12
pushed a commit
that referenced
this pull request
Feb 19, 2025
* feat: only throw for errors - except __gap overwrite * ci: storage check should fail * ci: storage check should fail * perf: optimize storage ci * fix: remove bad variable * chore: forge fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Storage layout checker was incorrectly treating
__gapvariable overrides as critical errors, despite this being their intended use in upgradeable contracts.Modifications:
__gapvariablesResult:
Script now properly validates storage layout changes, only failing on actually dangerous modifications while allowing intended gap usage.