feat: rewards v2.1 #1011
Merged
feat: rewards v2.1 #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a PR description + link to previous PR? |
0xrajath
reviewed
Jan 13, 2025
wadealexc
force-pushed
the
slashing-magnitudes-fixes
branch
from
1427a85 to
403e0a1
Compare
0xClandestine
force-pushed
the
feat/rewardsV2.1
branch
2 times, most recently
from
6ab18c0 to
ad3f18e
Compare
|
Initial IMPL LGTM. Holding off an approval till we get final scope: ad3f18e |
|
Can we add a test case for UAM on Rewards V2.1? |
0xrajath
reviewed
Jan 16, 2025
0xrajath
reviewed
Jan 16, 2025
0xrajath
reviewed
Jan 16, 2025
0xrajath
reviewed
Jan 16, 2025
0xrajath
reviewed
Jan 16, 2025
0xrajath
reviewed
Jan 17, 2025
0xrajath
reviewed
Jan 17, 2025
0xrajath
reviewed
Jan 17, 2025
0xrajath
reviewed
Jan 17, 2025
0xrajath
reviewed
Jan 21, 2025
0xClandestine
force-pushed
the
feat/rewardsV2.1
branch
from
6822ceb to
c572efb
Compare
feat: operator centric rewards feat: add new interfaces feat(wip): implement `createOperatorSetPerformanceRewardsSubmission` chore: forge fmt fix: compile feat(wip): implement `setOperatorSetOperatorSplit` fix: review changes fix: add missing `onlyWhenPaused` + `checkCanCall` feat(wip): add missing `getOperatorSetPerformanceSplit` + rename internals test(wip): `setOperatorSetPerformanceSplit` test(wip): `createOperatorSetPerformanceRewardsSubmission` - some failing chore: forge fmt refactor: renaming chore: storage report refactor: review changes refactor: review changes fix: gap refactor: review changes
0xClandestine
force-pushed
the
feat/rewardsV2.1
branch
from
c14e824 to
ce95040
Compare
0xrajath
reviewed
Jan 29, 2025
nadir-akhtar
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
All looks good security-wise. Minimal Solidity diff that parallels our existing implementation.
The storage layout checker is failing, though this is expected. It fails because it detects a diff between the storage layout of this contract between dev and this branch -- however, we're intentionally adding in 2 new storage slot variables, so no surprise.
The Certora checks are failing here, but also failing on dev, though not sure why
Good to go cc @0xrajath @0xClandestine
ypatil12
approved these changes
Jan 29, 2025
Merged
ypatil12
pushed a commit
that referenced
this pull request
Feb 19, 2025
* feat: rewards v2.1 feat: operator centric rewards feat: add new interfaces feat(wip): implement `createOperatorSetPerformanceRewardsSubmission` chore: forge fmt fix: compile feat(wip): implement `setOperatorSetOperatorSplit` fix: review changes fix: add missing `onlyWhenPaused` + `checkCanCall` feat(wip): add missing `getOperatorSetPerformanceSplit` + rename internals test(wip): `setOperatorSetPerformanceSplit` test(wip): `createOperatorSetPerformanceRewardsSubmission` - some failing chore: forge fmt refactor: renaming chore: storage report refactor: review changes refactor: review changes fix: gap refactor: review changes * fix: storage layout * chore: make storage-report * docs: natspec * refactor: review changes * refactor: review changes * refactor: review changes * feat: rewards v2.1 bindings * fix: not index operatorSet in events * refactor: forge fmt * docs: updated storage reports * chore: updated bindings --------- Co-authored-by: 0xrajath <[email protected]>
ypatil12
pushed a commit
that referenced
this pull request
Feb 21, 2025
* feat: rewards v2.1 feat: operator centric rewards feat: add new interfaces feat(wip): implement `createOperatorSetPerformanceRewardsSubmission` chore: forge fmt fix: compile feat(wip): implement `setOperatorSetOperatorSplit` fix: review changes fix: add missing `onlyWhenPaused` + `checkCanCall` feat(wip): add missing `getOperatorSetPerformanceSplit` + rename internals test(wip): `setOperatorSetPerformanceSplit` test(wip): `createOperatorSetPerformanceRewardsSubmission` - some failing chore: forge fmt refactor: renaming chore: storage report refactor: review changes refactor: review changes fix: gap refactor: review changes * fix: storage layout * chore: make storage-report * docs: natspec * refactor: review changes * refactor: review changes * refactor: review changes * feat: rewards v2.1 bindings * fix: not index operatorSet in events * refactor: forge fmt * docs: updated storage reports * chore: updated bindings --------- Co-authored-by: 0xrajath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator Set Performance Rewards
Adds support for AVSs to distribute performance-based rewards to operator sets.
New Functions
createOperatorDirectedOperatorSetRewardsSubmission()- Allows AVSs to submit rewards for specific operator setssetOperatorSetSplit()- Enables operators to set their reward split percentage for a given operator setgetOperatorSetSplit()- Returns the current split percentage for an operator in a specific setNew Storage
_operatorSetSplitBips- Maps operator addresses to their split percentages per operator setisOperatorDirectedOperatorSetRewardsSubmissionHash- Tracks processed reward submission hashesNew Events
OperatorSetSplitBipsSet- Emitted when an operator updates their split percentageOperatorDirectedOperatorSetRewardsSubmissionCreated- Emitted when an AVS submits new rewards