This repository was archived by the owner on Feb 7, 2022. It is now read-only.
Make library more generic with option to inject components #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option to inject highlighter condition
Adding isRootCollapsed prop
Fixes on highlights
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to inject filterer
added option to inject highlighter condition
This is needed for cases that we want advanced search algorithm on the json tree, for example find value on a specific json node.
For this case we also need to set a different condition to the highlighter, so we will highlight the relevant data found by the filterer.
This gives also a workarounf for the open issue of searching in ignore case mode, in that case a multi case value will not be highlighted, unless using the injected highlighter condition