Skip to content

refactor: migrate to PHP 8.4 and Symfony 6.4 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: migrate to PHP 8.4 and Symfony 6.4 #128

wants to merge 1 commit into from

Conversation

@PedroTroller
Copy link
Member

@PedroTroller PedroTroller commented Sep 16, 2025 •
edited
Loading

This PR introduces a major technical overhaul of the advanced training codebase, including the following updates:

  • PHP Upgrade: Migrated to PHP 8.4 (the latest stable version as of today) to leverage the newest language features and optimizations.
  • Symfony Downgrade: Rolled back to Symfony 6.4 (LTS) to ensure long-term stability and avoid frequent minor version migrations.
  • PHP-CS-Fixer Integration: Added a code standardization tool to maintain consistency and readability.
  • New CI Configuration: Implemented a continuous integration pipeline to automatically check for deprecations and ensure code quality.

@PedroTroller PedroTroller force-pushed the refactor/php84-symfony64 branch 10 times, most recently from a87cee9 to c31f95e Compare September 16, 2025 12:45
@PedroTroller PedroTroller force-pushed the refactor/php84-symfony64 branch from c31f95e to 92b4439 Compare September 16, 2025 12:47
@PedroTroller PedroTroller marked this pull request as ready for review September 16, 2025 12:49
clementvtrd
clementvtrd reviewed Sep 16, 2025
View reviewed changes
Dockerfile
Comment on lines +11 to +29
RUN addgroup docker \
&& adduser -S -h /home/docker -u 1000 -G docker docker \
&& chown -R docker /home/docker /usr/src/app \
&& apk add --no-cache --virtual=.build-deps \
autoconf==2.71-r2 \
g++==13.2.1_git20231014-r0 \
make==4.4.1-r2 \
&& docker-php-ext-configure intl \
&& docker-php-ext-install -j"$(nproc)" intl pdo_mysql \
&& pecl install apcu \
&& docker-php-ext-enable apcu intl \
$PHPIZE_DEPS \
&& apk add --no-cache \
bash \
git \
icu-dev \
&& docker-php-ext-configure \
intl \
&& docker-php-ext-install -j"$(nproc)" \
intl \
pdo_mysql \
&& pecl install \
apcu \
&& docker-php-ext-enable \
apcu \
intl \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu ne lock plus la version installée ? Hadolint ne crie pas ? 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce que j'ai voulu faire c'est de ne pas avoir à repasser sur le projet tous les deux jours, c'est pour ça que c'est pas une version de patch que j'ai donné pour php et que j'ai pas précisé de version pour alpine. On a pas de contrainte de prod (qui nous pousse à préciser les versions de paquets).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est pas faux :) Est-ce qu'on peut prévoir un build hebdomadaire avec la CI pour s'assurer que tout build chaque lundi par exemple ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah il faut rebase chaque branche et chaque commit de chaque module avancé alors... gros boulot. L0 je vais essayer de faire tourner la CI sur chaque commit mais je ne sais pas si on est capable de rebuild chaque semaine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oui c'est vrai chaque module a sa propre branche, j'avais un peu zappé cette partie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineGonzalez AntoineGonzalez AntoineGonzalez approved these changes

@clementvtrd clementvtrd clementvtrd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PedroTroller @AntoineGonzalez @clementvtrd