Skip to content

Conversation

christiangnrd
Copy link
Collaborator

@christiangnrd christiangnrd commented May 29, 2025

I went with the approach of changing the default value in load_accelerate.

@ViralBShah Should we be passing in the clear kwarg to both calls to forward_accelerate?

forward_accelerate(:lp64; new_lapack=true, clear, verbose)
if load_ilp64
forward_accelerate(:ilp64; new_lapack=true, verbose)
end

Fix #78

@christiangnrd christiangnrd changed the title Don’t clear symbols Don’t clear symbols when forwarding lapack May 29, 2025
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (b12ceba) to head (c67fa49).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   73.22%   75.73%   +2.51%     
==========================================
  Files           4        4              
  Lines         239      239              
==========================================
+ Hits          175      181       +6     
+ Misses         64       58       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah
Copy link
Member

The default for clear is false. So not necessarily, but also no harm.

Let's add a comment on why we are doing this. Basically, not clearing the forwards means BLAS/LAPACK bindings will forward to openblas unless overwrriten by bindings in Accelerate. So this way gemmt will go to openblas.

@christiangnrd
Copy link
Collaborator Author

christiangnrd commented May 30, 2025

Should be good to go.

@ViralBShah ViralBShah merged commit 803def5 into master May 30, 2025
10 checks passed
@ViralBShah ViralBShah deleted the christiangnrd-patch-1 branch May 30, 2025 15:00
@ViralBShah
Copy link
Member

Released this in a new version. Needed various other updates for the registry URL and TagBot which are all done too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppleAccelerate does not provide a gemmt function.

2 participants