Skip to content

Conversation

christiangnrd
Copy link
Member

This method will be more resilient for if/when we support broadcasted containers and not just AbstractArrays.

@anicusan
Copy link
Member

Hmm, I like the idea, but it'd still call get_backend on inputs; we wanted to avoid that when backend is explicitly specified, so that unmaterialised arrays (e.g. UnitRange) would work in GPU kernels.

A bit of a nitpick, but could we rename use_KA_algo to something fully snake_case to be consistent with the rest of the library? Perhaps use_gpu_backend? It can technically work on CPUs via PoCL, but it still goes through the GPUCompiler infrastructure, which is the main thing here.

Also, is there a way to have the buildkite badges in the README point to the latest merged commit? No problem if not.

@christiangnrd
Copy link
Member Author

I misread and accidentally changed it to use_gpu_algo instead of use_gpu_backend. I like it but happy to change it if you want.

It now takes in the provided backend.

Also, is there a way to have the buildkite badges in the README point to the latest merged commit? No problem if not.

I have no idea there.

@anicusan anicusan merged commit f7079dc into JuliaGPU:main Jul 22, 2025
39 checks passed
@christiangnrd christiangnrd deleted the algoselec branch July 22, 2025 15:17
@christiangnrd
Copy link
Member Author

Also, is there a way to have the buildkite badges in the README point to the latest merged commit? No problem if not.

@anicusan I found the answer while doing some unrelated troubleshooting. Adding ?branch=main to the badge url seems to be what you're looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants