Provide public API for ResourceContentHash annotation generation #5402
Conversation
pjBooms
force-pushed
the
pjBooms/resource-content-hash-annotation-gradle-api
branch
from
73190cc to
1c4def7
Compare
pjBooms
force-pushed
the
pjBooms/resource-content-hash-annotation-gradle-api
branch
from
1c4def7 to
b0d1112
Compare
| .map { it.toBoolean() } | ||
| .orElse(false) | ||
| ) | ||
| task.generateResourceContentHashAnnotation.set(false) |
| @@ -31,9 +42,6 @@ internal abstract class GenerateResourceAccessorsTask : IdeaImportTask() { | |||
| @get:Input | |||
| abstract val makeAccessorsPublic: Property<Boolean> | |||
|
|
|||
| @get:Input | |||
| abstract val generateResourceContentHashAnnotation: Property<Boolean> | |||
There was a problem hiding this comment.
add an init block with:
init {
generateResourceContentHashAnnotation.convention(false)
}https://docs.gradle.org/current/javadoc/org/gradle/api/provider/Property.html#convention(T)
| * Defines a property responsible for enabling or disabling | ||
| * generation of @ResourceContentHash annotation for resource accessors. | ||
| */ | ||
| interface ResourceContentHashAnnotationGenerationConfiguration { |
There was a problem hiding this comment.
Rename to ResourceAccessorsConfiguration
| internal abstract class GenerateResourceAccessorsTask : IdeaImportTask(), | ||
| ResourceContentHashAnnotationGenerationConfiguration | ||
| { |
There was a problem hiding this comment.
internal abstract class GenerateResourceAccessorsTask :
IdeaImportTask(),
ResourceContentHashAnnotationGenerationConfiguration {
//...
}There was a problem hiding this comment.
Fits to one line now
| @get:Input | ||
| abstract val generateResourceContentHashAnnotation: Property<Boolean> | ||
|
|
There was a problem hiding this comment.
we need inputs here (not in the interface)
There was a problem hiding this comment.
It is inherited from the interface. What is wrong with such properties?
pjBooms
force-pushed
the
pjBooms/resource-content-hash-annotation-gradle-api
branch
from
31f30e0 to
22dd6d0
Compare
| * Configuration for resource accessors generation. | ||
| * | ||
| * ### Properties | ||
| * - `generateResourceContentHashAnnotation`: |
There was a problem hiding this comment.
This is not by KDoc format. It needs to be moved this way:
/**
* Configuration for resource accessors generation.
*/
interface ResourceAccessorsConfiguration {
/**
* A property that defines whether to generate `@ResourceContentHash` annotation for resource accessors.
*/
val generateResourceContentHashAnnotation: Property<Boolean>
}
Please, also describe what is ResourceContentHash and why it is needed to override the behavior. Even if it is only for one client, maintainers should understand why this is added.
| @@ -14,7 +14,18 @@ import java.io.File | |||
| import java.nio.file.Path | |||
| import kotlin.io.path.relativeTo | |||
|
|
|||
There was a problem hiding this comment.
Please specify Release Notes, with an example how to set this new property
MatkovIvan
changed the title
The API is going to be used from Compose Hot Reload.
Release Notes
N/A