Fix #9 #12: Add configuration to disable subagent notifications #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 'enableSubagentNotifications' config option (default: false) - Modified notification handler to check config before sending subagent notifications - Created documentation explaining the feature - Updated README with note about subagent notifications This addresses the issue where frequent subagent notifications can be distracting. Users can now control whether they receive notifications when subagents stop/start. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Track subagent activities instead of sending individual notifications - Include subagent activity summary in completion emails - Update email templates to display subagent activities - Add SubagentTracker utility to manage activity tracking - Update documentation to explain the new behavior This provides a better user experience by: 1. Reducing notification noise from frequent subagent activities 2. Still providing full visibility into what subagents did 3. Consolidating all information in the completion email 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Enhanced activity capture to include up to 1000 characters (was 200) - Improved email display format with better visual separation - Added detection for initialization-only captures with helpful message - Added configuration option for activity detail level - Created comprehensive documentation explaining the timing limitation - Added visual indicators for processing status This addresses the issue where subagent outputs were truncated or only showed initialization messages. Users now get better visibility into what subagents are doing, with clear indication when full output is available in tmux. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
@JessyTsui The conflict doesn’t seem critical since the .json files are used as a local database. I’d actually suggest adding them to .gitignore to avoid future conflicts. As for the README change — it’s because the subagent hook feature is now integrated into the main mail thread, so there’s no need to keep it disabled by default anymore. And the subagent function demo looks like this: |
- Add _escapeHtml function to properly escape HTML entities in emails - Escape user-generated content to prevent HTML tags from being hidden - Fix issue where <developer> and other HTML-like strings disappeared in emails - Apply escaping to both main email content and subagent activity summaries 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
I solve the conflict, update some of the README (wrong date and add some notes for usage), and fix #12. |
|
@vaclisinc Great design decision to solve the notification noise issue. The PR mentions |
|
@JessyTsui Thanks! I had removed those two docs to keep the PR cleaner — they were just internal explanations generated by claude code. Here’s a quick summary:
Happy to restore the docs if you think they’re useful to keep (in my older commit)! |
vaclisinc
changed the title
|
Cool Let's merge it |
vaclisinc
added a commit
to vaclisinc/Claude-Code-Remote
that referenced
this pull request
Aug 1, 2025
- Added entry for subagent notifications configuration (PR JessyTsui#10) - Added entry for execution trace feature (issue JessyTsui#11) - Maintained chronological order in changelog 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
JessyTsui
added a commit
that referenced
this pull request
Aug 1, 2025
* Add configuration option to disable subagent notifications - Added 'enableSubagentNotifications' config option (default: false) - Modified notification handler to check config before sending subagent notifications - Created documentation explaining the feature - Updated README with note about subagent notifications This addresses the issue where frequent subagent notifications can be distracting. Users can now control whether they receive notifications when subagents stop/start. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Add subagent activity tracking in completion emails - Track subagent activities instead of sending individual notifications - Include subagent activity summary in completion emails - Update email templates to display subagent activities - Add SubagentTracker utility to manage activity tracking - Update documentation to explain the new behavior This provides a better user experience by: 1. Reducing notification noise from frequent subagent activities 2. Still providing full visibility into what subagents did 3. Consolidating all information in the completion email 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Improve subagent activity details and documentation - Enhanced activity capture to include up to 1000 characters (was 200) - Improved email display format with better visual separation - Added detection for initialization-only captures with helpful message - Added configuration option for activity detail level - Created comprehensive documentation explaining the timing limitation - Added visual indicators for processing status This addresses the issue where subagent outputs were truncated or only showed initialization messages. Users now get better visibility into what subagents are doing, with clear indication when full output is available in tmux. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * delete redundant files and modify README * Fix HTML escaping in email notifications - Add _escapeHtml function to properly escape HTML entities in emails - Escape user-generated content to prevent HTML tags from being hidden - Fix issue where <developer> and other HTML-like strings disappeared in emails - Apply escaping to both main email content and subagent activity summaries 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Add full execution trace to email notifications - Add getFullExecutionTrace method to capture complete terminal output - Include execution trace in a scrollable section within emails - Add CSS styling for visible scrollbars on desktop - Clean trace output by removing command prompt boxes - Add fallback message when trace is not available This addresses issue #11 - providing transparency about task execution 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Redesign email notification UI with improved terminal aesthetics - Reorganize content hierarchy: user request at top, response second, trace at bottom - Preserve terminal-style commands ($ cat, $ claude-code execute, etc.) - Remove redundant session info footer - Implement smart execution trace capture from user input to completion - Add TraceCapture utility to track user input timestamps - Improve visual hierarchy while maintaining terminal aesthetics - Use border colors (orange for user, green for success) for better distinction - Make execution trace collapsible and de-emphasized This improves readability while preserving the terminal charm of the project. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix execution trace filtering to show only recent activity - Change filter logic to find LAST user input instead of first - Search backwards through content to find most recent "> " prompt - Only include content from that point forward - Add fallback to show last 100 lines if no user input found - This ensures trace shows only relevant recent execution, not entire history 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Remove duplicate content from execution trace - Skip the first user input line (already shown in main content) - Skip the last Claude response (already shown in main content) - Only show intermediate execution steps and tool usage - Clean up empty lines at beginning and end - This avoids redundancy and focuses trace on execution details 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix execution trace to properly remove complete user input and output - Track multi-line user input and skip all continuation lines - Detect when user input ends (empty line or next command) - Stop before the last Claude response to avoid truncation - Only show intermediate execution steps between input and output This ensures the trace shows the complete execution process without duplicating content already displayed in the main sections. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix multi-line user input capture and trace filtering - Capture complete multi-line user input (not just first line) - Join continuation lines with spaces for proper display - Preserve all execution details in trace (tool calls, outputs) - Only skip user input and final response, keep everything in between * Add configuration toggle for subagent activities in email - Added 'showSubagentActivitiesInEmail' config option (default: false) - Modified claude-remote.js to check config before including subagent activities - Created documentation explaining the configuration - Allows users to choose between concise emails (execution trace only) or detailed emails (both summaries) This addresses the redundancy between execution trace and subagent activities summary, giving users control over email content. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix Git merge conflict in email template and document subagent config - Removed Git merge conflict markers from email text template - Added documentation for showSubagentActivitiesInEmail config in README - Explained that subagent activities are disabled by default for concise emails 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Update README changelog for PR #10 and issue #11 - Added entry for subagent notifications configuration (PR #10) - Added entry for execution trace feature (issue #11) - Maintained chronological order in changelog 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * delete redundant files * fix #15: add local database into .gitignore * Fix execution trace display in email notifications - Remove collapsible details tag for better email client compatibility - Add configuration option to toggle execution trace display - Fix HTML escaping issue for executionTraceSection variable 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Remove data files from git tracking These session-specific data files should not be tracked in version control as they are machine-specific and cause issues when pulling on other machines. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * fix typo(?) in changelog (#13) --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Naich <[email protected]> Co-authored-by: JessyTsui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
1. Configuration Option
enableSubagentNotificationsconfig option (defaults tofalse)2. Activity Tracking
SubagentTrackerutility to record subagent activities3. Improved Display
4. HTML escaping problem
_escapeHtmlfunction to escape HTML entities<developer>) were beinghidden
Test Plan
Fixes #9
Fixes #12