Skip to content

Conversation

AshishRamesh
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@javizqh javizqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values must not be hardcoded

@AshishRamesh
Copy link
Collaborator Author

removed hard coded values

@AshishRamesh AshishRamesh requested a review from javizqh March 12, 2025 16:49
Copy link
Collaborator

@javizqh javizqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coordinantes 0,0 are valid

@AshishRamesh
Copy link
Collaborator Author

ive fixed it , now uses the time stamp instead so avoids filtering any valid coordinates.
Side note while looking for possible solutions i noticed that most service robot exercises use hardcoded values (init coords and start coords) to get around this. Should i rectify them in another pr ??

@AshishRamesh AshishRamesh requested a review from javizqh March 12, 2025 18:32
@AshishRamesh
Copy link
Collaborator Author

Hi , any changes to be made for this ?

@javizqh javizqh merged commit 1f63ec7 into JdeRobot:humble-devel Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants