Skip to content

fix: shouldn't compare boolean with string #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2024
Merged

fix: shouldn't compare boolean with string #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
default: 'true'
type: boolean
version:
description: 'Version to tag (leave empty to use pyproject.toml version)'
description: 'Version (without v prefix) to tag (leave empty to use pyproject.toml version)'
required: false
type: string
pull_request:
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
- name: Create and push tag
id: create-tag
if: |
(github.event_name == 'workflow_dispatch' && inputs.create_tag == 'true') ||
(github.event_name == 'workflow_dispatch' && inputs.create_tag) ||
(github.event_name == 'pull_request' && steps.version-check.outputs.changed == 'true')
run: |
VERSION=${{ steps.version-check.outputs.version }}
Expand Down
Loading