Skip to content

Build consensus in GitHub actions #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 21, 2021
Merged

Build consensus in GitHub actions #2806

merged 6 commits into from
Jan 21, 2021

Conversation

@newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Dec 11, 2020 •
edited
Loading

  • Add MacOS builds
  • Add consensus builds as separate jobs
  • Introduce CACHE_VERSION to make it easy to "invalidate" the cabal store cache
  • Work around setup-haskell, ghcup bugs
  • Build with cabal-3.4-rc4 for better caching and faster builds

@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch from 7cc7b23 to 50bd30f Compare December 15, 2020 03:52
mrBliss
mrBliss reviewed Dec 15, 2020
View reviewed changes
@mrBliss
Copy link
Contributor

mrBliss commented Dec 15, 2020

I think something went wrong while rebasing?

@newhoggy
Copy link
Contributor Author

I think something went wrong while rebasing?

It failed because ouroboros-consensus doesn't have tests.

@mrBliss
Copy link
Contributor

mrBliss commented Dec 15, 2020

I think something went wrong while rebasing?

It failed because ouroboros-consensus doesn't have tests.

No, I'm talking about the three commits in this PR that are from master.

The tests of ouroboros-consensus live in ouroboros-consensus-test (-test-consensus and -test-storage).

@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch 2 times, most recently from 0f2a871 to 2f3876f Compare December 15, 2020 08:31
@newhoggy
Copy link
Contributor Author

No, I'm talking about the three commits in this PR that are from master

Ah yes. I've removed them. Not sure how they got there.

@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch from 2f3876f to e6439dd Compare December 15, 2020 08:34
@newhoggy
Copy link
Contributor Author

I pushed some changes to make the consensus stuff build on Linux only.

@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch 9 times, most recently from eb450dc to 87aaf4a Compare December 17, 2020 23:19
mrBliss
mrBliss reviewed Dec 18, 2020
View reviewed changes
@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch 10 times, most recently from c2d06d8 to 3999a90 Compare December 24, 2020 00:40
nfrisby
nfrisby reviewed Jan 9, 2021
View reviewed changes
@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch 2 times, most recently from d12ba30 to 279f901 Compare January 11, 2021 09:06
@newhoggy newhoggy mentioned this pull request Jan 11, 2021
Closed
@newhoggy newhoggy requested review from coot and nfrisby January 11, 2021 21:03
nfrisby
nfrisby reviewed Jan 12, 2021
View reviewed changes
nfrisby
nfrisby reviewed Jan 12, 2021
View reviewed changes
@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch from 279f901 to d7c4bfd Compare January 13, 2021 05:44
@newhoggy newhoggy requested a review from nfrisby January 13, 2021 05:44
@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch 4 times, most recently from 126eb97 to b1347e1 Compare January 20, 2021 05:04
@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch from b1347e1 to c40bc8e Compare January 21, 2021 03:56
@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch from c40bc8e to 4688016 Compare January 21, 2021 06:43
nfrisby
nfrisby approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the back and forth. LGTM.

I'm Approving, because it's not crucial, but I'm pretty sure @coot said somewhere (I forget) that the issue 1818 comment can be dropped; it's resolved.

@newhoggy newhoggy force-pushed the build-consensus-in-github-actions branch from da5b4d9 to cebe5b9 Compare January 21, 2021 14:13
@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 457b63c into master Jan 21, 2021
@iohk-bors iohk-bors bot deleted the build-consensus-in-github-actions branch January 21, 2021 15:24
@nfrisby
Copy link
Contributor

nfrisby commented Jan 21, 2021

Thanks for this, @newhoggy for introducing it and owning it (for the foreseeable future at least). I look forward to seeing it catch some Windows/8.6.5/etc regressions! :)

@newhoggy
Copy link
Contributor Author

Thanks for all your help getting this through. It means in future, when there are down stream compile issues we can very quickly rule out upstream issues by pointing to recent successful CI builds. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfrisby nfrisby nfrisby approved these changes

@mrBliss mrBliss Awaiting requested review from mrBliss

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@coot coot Awaiting requested review from coot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@newhoggy @mrBliss @nfrisby @coot