CAD-737 eliding BlockFetchDecision messages #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Diemand <[email protected]>
CodiePP
added
maintenance
|
Build and run node with: Looks like messages are being elided now: CC: @CodiePP |
CodiePP
changed the title
ArturWieczorek
approved these changes
Mar 20, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 20, 2020
701: CAD-737 eliding BlockFetchDecision messages r=CodiePP a=CodiePP Issue ----------- - eliding messages `BlockFetchDecision` (issue #666 ) - This PR **does not result** in breaking changes to upstream dependencies. Checklist --------- - [x] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [ ] The work has sufficient tests and/or testing. - [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [x] I have added the appropriate labels to this PR. 702: add selfnode environment r=oneEdoubleD a=disassembler * removes no longer used genesis file/hash Issue ----------- - - This PR **results**/**does not result** in breaking changes to upstream dependencies. Checklist --------- - [ ] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [ ] The work has sufficient tests and/or testing. - [ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [ ] I have added the appropriate labels to this PR. Co-authored-by: Alexander Diemand <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 20, 2020
701: CAD-737 eliding BlockFetchDecision messages r=CodiePP a=CodiePP Issue ----------- - eliding messages `BlockFetchDecision` (issue #666 ) - This PR **does not result** in breaking changes to upstream dependencies. Checklist --------- - [x] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [ ] The work has sufficient tests and/or testing. - [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [x] I have added the appropriate labels to this PR. 702: add selfnode environment r=disassembler a=disassembler * removes no longer used genesis file/hash Issue ----------- - - This PR **results**/**does not result** in breaking changes to upstream dependencies. Checklist --------- - [ ] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [ ] The work has sufficient tests and/or testing. - [ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [ ] I have added the appropriate labels to this PR. Co-authored-by: Alexander Diemand <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 20, 2020
701: CAD-737 eliding BlockFetchDecision messages r=CodiePP a=CodiePP Issue ----------- - eliding messages `BlockFetchDecision` (issue #666 ) - This PR **does not result** in breaking changes to upstream dependencies. Checklist --------- - [x] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [ ] The work has sufficient tests and/or testing. - [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [x] I have added the appropriate labels to this PR. Co-authored-by: Alexander Diemand <[email protected]>
Build failed |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
eliding messages
BlockFetchDecision(issue CAD-737 Apply message eliding to BlockFetchDecision:Info "kind":"FetchDecision" #666 )This PR does not result in breaking changes to upstream dependencies.
Checklist
This PR contains all the work required to resolve the linked issue.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.