Skip to content

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Mar 3, 2020

Issue #618

  • adapt configurations to namespace changes, correctly routing metrics to EKG and LiveView backends

  • This PR does not result in breaking changes to upstream dependencies.

Checklist

  • This PR contains all the work required to resolve the linked issue.

  • The work contained has sufficient documentation to describe what it does and how to do it.

  • The work has sufficient tests and/or testing.

  • I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

  • I have added the appropriate labels to this PR.

@CodiePP CodiePP added the bug Something isn't working label Mar 3, 2020
@CodiePP CodiePP added this to the S8 2020-03-12 milestone Mar 3, 2020
@CodiePP CodiePP added the byron Required for a Byron mainnet: replace the old core nodes with cardano-node. label Mar 3, 2020
@CodiePP CodiePP linked an issue Mar 3, 2020 that may be closed by this pull request
@oneEdoubleD
Copy link
Contributor

This has fixed the issue with the critical messages! Here's a snippet of the logs after this change:

[edward:cardano.node.ChainDB.text:Notice:40] [2020-03-03 13:41:56.39 UTC] [a34dccc@3611] Copied block (Point 1450, da4bd67b0edb0f77) to the ImmutableDB
[edward:cardano.node.ChainDB:Info:36] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceAddBlockEvent.AddBlockValidation.ValidCandidate","block":"1e2546c@3612"},"kind":"TraceEvent","tip":"a34dccc@3611"}
[edward:cardano.node.ChainDB.text:Info:36] [2020-03-03 13:41:56.39 UTC] [a34dccc@3611] Valid candidate (Point 3612, 1e2546c6893675dc)
[edward:cardano.node.ChainDB:Notice:40] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceCopyToImmDBEvent.CopiedBlockToImmDB","slot":{"kind":"Tip","tip":"e646e08@1451"}},"kind":"TraceEvent","tip":"a34dccc@3611"}
[edward:cardano.node.ChainDB:Notice:36] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"1e2546c@3612"},"kind":"TraceEvent","tip":"a34dccc@3611"}
[edward:cardano.node.ChainDB.text:Notice:40] [2020-03-03 13:41:56.39 UTC] [a34dccc@3611] Copied block (Point 1451, e646e081ea51a962) to the ImmutableDB
[edward:cardano.node.ChainDB.text:Notice:36] [2020-03-03 13:41:56.39 UTC] [a34dccc@3611] Chain extended, new tip: (Point 3612, 1e2546c6893675dc)
[edward:cardano.node.ChainDB:Info:36] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceAddBlockEvent.AddBlockValidation.ValidCandidate","block":"5231b9c@3613"},"kind":"TraceEvent","tip":"1e2546c@3612"}
[edward:cardano.node.ChainDB.text:Info:36] [2020-03-03 13:41:56.39 UTC] [1e2546c@3612] Valid candidate (Point 3613, 5231b9c71a76195d)
[edward:cardano.node.ChainDB:Notice:40] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceCopyToImmDBEvent.CopiedBlockToImmDB","slot":{"kind":"Tip","tip":"cb8b32a@1452"}},"kind":"TraceEvent","tip":"1e2546c@3612"}
[edward:cardano.node.ChainDB.text:Notice:40] [2020-03-03 13:41:56.39 UTC] [1e2546c@3612] Copied block (Point 1452, cb8b32abf4a62ed8) to the ImmutableDB
[edward:cardano.node.ChainDB:Notice:36] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"5231b9c@3613"},"kind":"TraceEvent","tip":"1e2546c@3612"}
[edward:cardano.node.ChainDB.text:Notice:36] [2020-03-03 13:41:56.39 UTC] [1e2546c@3612] Chain extended, new tip: (Point 3613, 5231b9c71a76195d)
[edward:cardano.node.ChainDB:Notice:40] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceCopyToImmDBEvent.CopiedBlockToImmDB","slot":{"kind":"Tip","tip":"1e6e8bb@1453"}},"kind":"TraceEvent","tip":"1e2546c@3612"}
[edward:cardano.node.ChainDB.text:Notice:40] [2020-03-03 13:41:56.39 UTC] [1e2546c@3612] Copied block (Point 1453, 1e6e8bb9c8da5d07) to the ImmutableDB
[edward:cardano.node.ChainDB:Info:36] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceAddBlockEvent.AddBlockValidation.ValidCandidate","block":"82f1fb8@3614"},"kind":"TraceEvent","tip":"1e2546c@3612"}
[edward:cardano.node.ChainDB.text:Info:36] [2020-03-03 13:41:56.39 UTC] [1e2546c@3612] Valid candidate (Point 3614, 82f1fb8f1a5d3160)
[edward:cardano.node.ChainDB:Notice:36] [2020-03-03 13:41:56.39 UTC] {"event":{"kind":"TraceAddBlockEvent.AddedToCurrentChain","newtip":"82f1fb8@3614"},"kind":"TraceEvent","tip":"1e2546c@3612"}
[edward:cardano.node.ChainDB:Info:5] [2020-03-03 13:41:56.39 UTC] {"event":{"immtip":{"kind":"Tip","tip":"1e6e8bb@1453"},"kind":"TraceOpenEvent.ClosedDB","tip":{"kind":"Tip","tip":"82f1fb8@3614"}},"kind":"TraceEvent","tip":"1e2546c@3612"}

Copy link
Contributor

@oneEdoubleD oneEdoubleD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that this fixes the issue locally - LGTM! :)

@CodiePP CodiePP requested a review from disassembler March 3, 2020 14:13
@CodiePP
Copy link
Contributor Author

CodiePP commented Mar 3, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 3, 2020

@iohk-bors iohk-bors bot merged commit 10d51f1 into master Mar 3, 2020
@iohk-bors iohk-bors bot deleted the cad-707-namespace-changes branch March 3, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CAD-707 ChainDB.metrics:Critical messages when syncing

2 participants