-
Notifications
You must be signed in to change notification settings - Fork 20
Better representation of minting values in the code #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better representation of minting values in the code #1085
Conversation
5b296e4
to
bbb2145
Compare
bbb2145
to
12e662a
Compare
03b775f
to
b55d002
Compare
96bb16e
to
568b12f
Compare
568b12f
to
61b1833
Compare
| --tx-out-inline-datum-value JSON_VALUE | ||
] | ||
[--tx-out-reference-script-file FILEPATH]] | ||
[--mint VALUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
<*> many pTxOut | ||
<*> pChangeAddress | ||
<*> optional (pMintMultiAsset sbe AutoBalance) | ||
<*> (fmap join . optional $ pMintMultiAsset sbe AutoBalance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can parameterize pMintMultiAsset
on MaryEraOnwards era
, remove the Maybe
from the type signature and call caseShelleyToAllegraOrMaryEraOnwards
here instead. I think that is cleaner but I wouldn't block the PR on it.
Changelog
Context
The minted amount was represented as
Value
which includes ADA. It was only guarded against "minting ada" in parser, not in the type. This PR changes the type to use ledger'sL.MultiAsset
, which contains only non-ADA assets.Also the minting options are removed from eras before Mary.
Requires changes from to build successfully:
CastVerificationKeyRole StakePoolExtendedKey StakePoolKey
instance cardano-api#782Checklist