Skip to content

Conversation

kevalmahajan
Copy link
Member

@kevalmahajan kevalmahajan commented Aug 19, 2025

🐛 Bug-fix PR


📌 Summary

Decode auth before trying to connect to sse and streamable http servers as the auth stored in db is encrypted.

🐞 Root Cause

As the auth for connection of mcp servers is authenticated and was not decrypted before connection, connection through sse and streamable http to the mcp servers failed.

💡 Fix Description

For auth_type as bearer, basic and custom headers, decrypt the auth before connection.

🧪 Verification

Check Command Status
Lint suite make lint
Unit tests make test
Coverage ≥ 90 % make coverage
Manual regression no longer fails steps / screenshots

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

Signed-off-by: Keval Mahajan <[email protected]>
@MohanLaksh
Copy link
Collaborator

PR Test Summary:

Successfully tested adding a sse server with auth and a streamablehttp server(github)
Successfully executed sample tools.

Good to Merge!

@crivetimihai crivetimihai merged commit 6070767 into main Aug 19, 2025
35 of 37 checks passed
@crivetimihai crivetimihai deleted the fix_authentication_servers branch August 19, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants