Skip to content

Conversation

MohanLaksh
Copy link
Collaborator

Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:
This PR makes the maximum allowed name length for input validation configurable via a settings value instead of being hardcoded (previously 100). It passes the value from the backend (Python/FastAPI) through the template into JavaScript as window.MAX_NAME_LENGTH, and updates error messages accordingly.

Issues:

  • No obvious issues with logic or security.
  • Make sure settings.validation_max_name_length is always set and numeric to avoid JS errors.
  • If not already tested, verify the new limit propagates correctly in all relevant UI interactions.

Passed: make lint-web doctest test

@crivetimihai crivetimihai merged commit f5b3e21 into IBM:main Aug 1, 2025
36 checks passed
@MohanLaksh
Copy link
Collaborator Author

PR Self Review Summary:

  1. make lint-web - success (found 0 vulnerabilities)
  2. make serve - working as intended
  3. make test - passed (80%, == 1127 passed, 10 skipped, 50 warnings in 46.06s ==)
  4. make autoflake isort black flake8 - 137 files left unchanged.
  5. make pylint - pass (Your code has been rated at 10.00/10 )
  6. make smoketest - ✅ Smoketest passed!
  7. make doctest - pass (58%, 372 passed, 8 skipped in 21.33s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants