Skip to content

Fix: Correctly parse array inputs in Test Tool UI #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025
Merged

Fix: Correctly parse array inputs in Test Tool UI #641

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7bd6a5
fix for tool input issue
shoummu1 Jul 30, 2025
f0eab20
Merge remote-tracking branch 'origin/main' into fix_tool_input
madhav165 Jul 30, 2025
0f36bda
lint-web fixes
madhav165 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 71 additions & 12 deletions mcpgateway/static/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3507,19 +3507,78 @@ async function runToolTest() {
}
let value;
if (prop.type === "array") {
value = formData.getAll(key);
if (prop.items && prop.items.type === "number") {
value = value.map((v) => (v === "" ? null : Number(v)));
} else if (prop.items && prop.items.type === "boolean") {
value = value.map((v) => v === "true" || v === true);
}
if (
value.length === 0 ||
(value.length === 1 && value[0] === "")
) {
continue;
const inputValues = formData.getAll(key);
try {
// Convert values based on the items schema type
if (prop.items && prop.items.type) {
switch (prop.items.type) {
case "object":
value = inputValues.map((v) => {
try {
const parsed = JSON.parse(v);
if (
typeof parsed !== "object" ||
Array.isArray(parsed)
) {
throw new Error(
`Value must be an object, got ${typeof parsed}`,
);
}
return parsed;
} catch (e) {
console.error(
`Error parsing object for ${key}:`,
e,
);
throw new Error(
`Invalid object format for ${key}. Each item must be a valid JSON object.`,
);
}
});
break;
case "number":
value = inputValues.map((v) =>
v === "" ? null : Number(v),
);
break;
case "boolean":
value = inputValues.map(
(v) => v === "true" || v === true,
);
break;
default:
// For other types (like strings), use raw values
value = inputValues;
}
} else {
// If no items type specified, use raw values
value = inputValues;
}

// Handle empty values
if (
value.length === 0 ||
(value.length === 1 && value[0] === "")
) {
if (
schema.required &&
schema.required.includes(key)
) {
params[keyValidation.value] = [];
}
continue;
}
params[keyValidation.value] = value;
} catch (error) {
console.error(
`Error parsing array values for ${key}:`,
error,
);
showErrorMessage(
`Invalid input format for ${key}. Please check the values are in correct format.`,
);
throw error;
}
params[keyValidation.value] = value;
} else {
value = formData.get(key);
if (value === null || value === undefined || value === "") {
Expand Down
Loading