Skip to content

Use X-Forwarded-Proto for URL correction #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 22, 2025
Merged

Use X-Forwarded-Proto for URL correction #562

merged 6 commits into from
Jul 22, 2025

Conversation

madhav165
Copy link
Collaborator

@madhav165 madhav165 commented Jul 21, 2025 •
edited
Loading

🐛 Bug-fix PR

📌 Summary

Issue #424

💡 Fix Description

  1. Forward X-Forwarded-Proto in gunicorn
  2. Update url sent to SSETransport to have the correct protocol based on X-Forwarded-Proto header or request URL scheme

🧪 Verification

Check Command Status
Lint suite make lint pass
Unit tests make test pass

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

madhav165 added 4 commits July 21, 2025 19:51
@madhav165
add proxyheaders firmware
22a19fb 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
fix import
634627f 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
update url with protocol
798cee6 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
linting fixes
ea347fd 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165 madhav165 self-assigned this Jul 21, 2025
@madhav165 madhav165 linked an issue Jul 21, 2025 that may be closed by this pull request
[Bug]: MCP Gateway Doesn't Detect HTTPS/TLS Context or respect X-Forwarded-Proto when using Federation #424
Closed
@madhav165 madhav165 added the bug Something isn't working label Jul 21, 2025
@madhav165 madhav165 marked this pull request as ready for review July 22, 2025 07:32
@madhav165
Copy link
Collaborator Author

test, smoketest, linting passed.
Test with make serve worked. Merging based on this.

@madhav165 madhav165 merged commit 855f5be into main Jul 22, 2025
26 checks passed
@madhav165 madhav165 deleted the use-tls-context branch July 22, 2025 07:34
@madhav165 madhav165 mentioned this pull request Jul 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crivetimihai crivetimihai Awaiting requested review from crivetimihai crivetimihai is a code owner

@kevalmahajan kevalmahajan Awaiting requested review from kevalmahajan kevalmahajan is a code owner

Assignees

@madhav165 madhav165

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: MCP Gateway Doesn't Detect HTTPS/TLS Context or respect X-Forwarded-Proto when using Federation
1 participant
@madhav165