Skip to content

Conversation

madhav165
Copy link
Collaborator

@madhav165 madhav165 commented Jul 18, 2025

🐛 Bug-fix PR

📌 Summary

Fixes bug #518

🐞 Root Cause

Using a single pubsub for all sessions

💡 Fix Description

Creating separate pububs for each session and closing them at the end of the session.

🧪 Verification

Check Command Status
Lint suite make lint pass
Unit tests make test pass

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

@madhav165 madhav165 requested a review from crivetimihai as a code owner July 18, 2025 13:28
@madhav165 madhav165 changed the title Use a separate pubsub for each session Signed-off-by: Madhav Kandukuri <[email protected]> Use a separate pubsub for each session Jul 18, 2025
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed make doctest test smoketest

@madhav165 madhav165 merged commit f0175b7 into main Jul 18, 2025
26 checks passed
@madhav165 madhav165 deleted the fix-session-bug branch July 18, 2025 13:52
@madhav165 madhav165 linked an issue Jul 18, 2025 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Runtime error from Redis when multiple sessions exist
2 participants