Skip to content

Conversation

madhav165
Copy link
Collaborator

@madhav165 madhav165 commented Jul 16, 2025

🐛 Bug-fix PR


📌 Summary

Fixes the computation of user_name and password in get_gateway function

🐞 Root Cause

  1. @classmethod used before @model_validator(mode="after") declaration. This was interfering the calling of the _populate_auth function
  2. auth_value was checked for username and password directly instead of within Authorization value.

🧪 Verification

Check Command Status
Unit tests make test pass

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165 madhav165 requested a review from crivetimihai as a code owner July 16, 2025 12:29
@madhav165 madhav165 self-assigned this Jul 16, 2025
@madhav165 madhav165 changed the title Fix auth populate for GET /gateways/<gateway_id> Fix _auth_populate in GatewayRead Jul 16, 2025
@madhav165 madhav165 marked this pull request as draft July 16, 2025 12:32
@madhav165 madhav165 marked this pull request as ready for review July 16, 2025 12:32
Signed-off-by: Madhav Kandukuri <[email protected]>
@crivetimihai crivetimihai merged commit 0143aa0 into main Jul 16, 2025
25 of 26 checks passed
@crivetimihai crivetimihai deleted the fix-populate-auth branch July 16, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: auth_username and auth_password not getting set in GET /gateways/<gateway_id> API [Bug]: _populate_auth not working
2 participants