Skip to content

Raise Pylint to 10/10 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Jul 11, 2025
Merged

Raise Pylint to 10/10 #385

merged 38 commits into from
Jul 11, 2025

Conversation

ChrisPC-39
Copy link
Collaborator

@ChrisPC-39 ChrisPC-39 commented Jul 11, 2025 •
edited
Loading

  • Pylint to 10/10.
  • Passes all unit tests.
  • Some TODOs still show up on Pylint.

Closes #210

Sebastian added 30 commits July 4, 2025 17:21
Pylint cli
c1b7238
Pylint sampling
c018e83
Pylint schemas
04dc14a
Pyling completion_services
0aeb05b
Pylint resource_service
fb5aa72
Pylint streamablehttp_transport
990f805
Pylint websocket_transport
7395d80
Pylint mcpgateway/admin.py
a367a84
Pylint mcpgateway/federation/discovery.py
5fe9566
Pylint mcpgateway/federation/forward.py
05d8759
Pylint mcpgateway/federation/manager.py
ca8ac74
Pylint mcpgateway/services/prompt_service.py
9f7bd3a
Pylint mcpgateway/services/server_service.py
9ef4880
Pylint mcpgateway/services/tool_service.py
76a3b22
Pylint mcpgateway/transports/sse_transport.py
a0f8ad5
Pylint mcpgateway/version.py
b54d172
Pylint mcpgateway/wrapper.py
f13ff90
Remove unneccessary pylint ignore comments
a582252
Load pylint-pydantic plugin in .pylintrc
7879638
Pylint mcpgateway/db.py
aa31a82
Pylint mcpgateway/main.py
10e0b61
Pylint mcpgateway/translate.py
4018f02
Pylint mcpgateway/cache/session_registry.py
c0568b9
Pylint mcpgateway/translate.py
0bd1de2 
Signed-off-by: Sebastian <[email protected]>
Pylint part of mcpgateway/services/gateway_service.py
ea51e0c 
Signed-off-by: Sebastian <[email protected]>
Fix typo in mcpgateway/translate.py
73331b0 
Signed-off-by: Sebastian <[email protected]>
Merge remote-tracking branch 'origin' into pylint_improvements
7afed7d
Merge main and small fixes
8b28b40 
Signed-off-by: Sebastian <[email protected]>
Fix typo in mcpgateway/cache/session_registry.py
8772289 
Signed-off-by: Sebastian <[email protected]>
Fix flake8
be9c0e3 
Signed-off-by: Sebastian <[email protected]>
@ChrisPC-39 ChrisPC-39 requested a review from crivetimihai as a code owner July 11, 2025 12:16
Sebastian added 2 commits July 11, 2025 16:52
Fix flake8
0a16ecd 
Signed-off-by: Sebastian <[email protected]>
Fix flake8 mcpgateway/schemas.py
f9e1634 
Signed-off-by: Sebastian <[email protected]>
crivetimihai
crivetimihai approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran make test smoketest flake8 pylint - looks good!

@crivetimihai
linting
c525345 
Signed-off-by: Mihai Criveti <[email protected]>
@crivetimihai crivetimihai merged commit d13d352 into IBM:main Jul 11, 2025
17 of 20 checks passed
@ChrisPC-39 ChrisPC-39 deleted the pylint_improvements branch July 11, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crivetimihai crivetimihai crivetimihai approved these changes

@kevalmahajan kevalmahajan Awaiting requested review from kevalmahajan kevalmahajan is a code owner

@madhav165 madhav165 Awaiting requested review from madhav165 madhav165 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE]: Raise pylint from 9.16/10 -> 10/10
2 participants
@ChrisPC-39 @crivetimihai