Add proper HTML escaping for admin UI user data rendering, and eliminate all web lint issues closes #336 #338 #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper HTML escaping for admin UI user data rendering
Closes #336 closes #338
Changes
escapeHtml()
function that escapes HTML special characterstextContent
for table cellssafeUrl()
helper for URL validationImpact
Testing
<img src=x onerror="alert('test')">
is properly escaped and displayed as textAdditional Improvements to Consider
Immediate:
Medium-term: