[Bug]:Tool Edit Screen Issues – Field Mismatch & MCP Tool Validation Error

[rakdutta]

There are two issues identified in the Tool Edit functionality:

1. Field Mismatch in Edit Screen

• Add Tool Screen: gateway_name and original_name fields are present.
• Edit Tool Screen: Points to name field instead of gateway_name/original_name.
• Impact: Users see different field mapping in Add vs. Edit, causing confusion and potential incorrect updates.

---

2. Blank integration_type & request_type in Edit MCP Tool

• For MCP tools, the integration_type and request_type fields appear blank in the edit screen, despite the database having correct values.
• When attempting to update such a tool, a validation error occurs:

request_type
  Input should be 'GET', 'POST', 'PUT', 'DELETE' or 'PATCH' [type=literal_error, input_value='SSE', input_type=str]
    For further information visit https://errors.pydantic.dev/2.11/v/literal_error
2025-08-11 14:35:09,113 - uvicorn.access - INFO - 127.0.0.1:36742 - "POST /admin/tools/e11f9b4340af40ba860773dc81ac9211/edit HTTP/1.1" 422

---

Steps to Reproduce:

1. Field mismatch issue:

   • Go to Add Tool screen → observe fields gateway_name & original_name.
   • Go to Edit Tool screen → observe it points to name instead.

2. MCP tool validation issue:

   • Edit any existing MCP tool from the admin UI.
   • Observe integration_type and request_type are blank.
   • Attempt to save → validation error appears.

---

Expected Behavior:

• Field consistency: gateway_name & original_name should be visible in both Add & Edit screens.
• MCP tool edit: Existing integration_type and request_type values should be pre-filled from the database to avoid validation errors.

---

Suggested Fix:

• Ensure field mapping in Edit Tool matches Add Tool (gateway_name & original_name).
• Pre-populate integration_type and request_type in edit form for MCP tools from DB values.

[rakdutta]

Tools Edit Form – Field Visibility & Editability Matrix

Column Name	Visible	Editable
original_name	Yes	Editable for all integration types except 'MCP'
original_name_slug	No	Editable for all integration types except 'MCP'
url	Yes	Editable for all integration types except 'MCP'
description	Yes	Yes
integration_type	Yes	Editable for all integration types except 'MCP'
request_type	Yes	Editable for all integration types except 'MCP'
headers	No	No
input_schema	Yes	TBD
annotations	Yes	Yes
jsonpath_filter	Yes	TBD
auth_type	Yes	TBD
auth_value	Yes	TBD
gateway_name	Yes	No
name	Yes	Yes — when integration_type = 'MCP', value must start with the gateway_name
tags	Yes	Yes

Notes:

• Visible = Field appears in the Tools Edit form UI.

• Editable = Field can be edited by the user.

• TBD = Logic to be decided (requires stakeholder confirmation).

• Conditional Rules:

  • For fields marked “No when integration_type = 'MCP'”, Visiable as read only.

  • For name in MCP, enforce validation so it starts with the value of gateway_name.

---

[madhav165]

@rakdutta Couple of comments based on my understanding.

1. auth_type and auth_value - Can be editable for all integration_type except MCP
2. jsonpath_filter - Editable

For name - we can do this

1. Add a new field - display_name which would be gateway_slug + separator + name_slug (of tool) (if MCP) or name_slug (if not MCP) - around line 1164 in db.py
2. name_slug should be calculated from name and update display_name every time name is updated
3. name would default to original_name
4. This way it is intuitive to API users what happens in the backend.

[rakdutta]

@madhav165

Updated Tools Edit Form – Field Visibility & Editability Matrix
This update includes a new column mapping for name, name_slug, and display_name, along with mockup data for mcp_type (current/future).

Column Name	Visible	Editable	Mapping	Current Values – MCP Integration_type	Future Values – MCP Integration_type	Current Values – REST Integration_type	Remarks
original_name	Yes	Editable for all integration types except 'MCP'		echo	echo	local-tool1
original_name_slug	No	Editable for all integration types except 'MCP'		echo		local-tool1
url	Yes	Editable for all integration types except 'MCP'		http://127.0.0.1:8000/sse	http://127.0.0.1:8000/sse	http://127.0.0.1:8000
description	Yes	Yes		Echoes back the input	Echoes back the input from MCP tool
integration_type	Yes	Editable for all integration types except 'MCP'		MCP	MCP	REST
request_type	Yes	Editable for all integration types except 'MCP'		SSE	SSE	GET
headers	No	No		{}	{}	{}
input_schema	Yes	TBD		{"properties": {"message": {"title": "Message", "type": "string"}}, "required": ["message"], "title": "EchoInput", "type": "object"}		{}
annotations	Yes	Yes		{}	testing	{}
jsonpath_filter	Yes	Yes			testing
auth_type	Yes	Editable for all integration types except 'MCP'		bearer	bearer
auth_value	Yes	Editable for all integration types except 'MCP'		(masked)	(masked)
gateway_name	Yes	No		mcp-server1	mcp-server1
name	Yes	Yes — when integration_type = 'MCP', value must start with gateway_name	Option 1: Name defaults to original_name, updates display_name every time name is updated. Option 2: In UI — keep gateway_name part read-only (disabled for editing) and allow only the suffix to be changed. In API — if integration_type == MCP and name does not start with gateway_name, throw error; only suffix change allowed.	mcp-server1-echo	mcp-server1-echo-tool		Option 1 Pros: Simple data sync between name and display_name, predictable behavior. Option 1 Cons: Needs two additional fields; more DB storage and maintenance. Option 2 Pros: No extra fields needed, clean logic in API; aligns with UI behavior. Option 2 Cons: Slightly more UI logic to handle prefix lock. Discussion Needed
tags	Yes	Yes		[]
name_slug	TBD	Should be calculated from name					Discussion Needed
display_name	Yes	Which would be gateway_slug + separator + name_slug (if MCP) or name_slug (if not MCP)					Discussion Needed

[rakdutta]

Updated Tools Edit Form – Field Visibility & Editability Matrix
Added new column mapping for name, name_slug, and custom_name.
Also added mockup data for MCP type (current/future).

Column Name	Visible	Editable	Mapping	Current Values-MCP Integration_type	Future Values-MCP Integration_type	Remarks
original_name	No	Editable for all integration types except 'MCP'		echo	echo
original_name_slug	No	No				delete this field
url	Yes	Editable for all integration types except 'MCP'		http://127.0.0.1:8000/sse	http://127.0.0.1:8000/sse
description	Yes	Yes		Echoes back the input	Echoes back the input from MCP tool
integration_type	Yes	Editable for all integration types except 'MCP'		MCP	MCP
request_type	Yes	Editable for all integration types except 'MCP'		SSE	SSE
headers	Yes	Editable for all integration types except 'MCP'
input_schema	Yes	Editable for all integration types except 'MCP'		{"properties": {"message": {"title": "Message", "type": "string"}}, "required": ["message"], "title": "EchoInput", "type": "object"}	{"properties": {"message": {"title": "Message", "type": "string"}}, "required": ["message"], "title": "EchoInput", "type": "object"}
annotations	Yes	Yes		{}	testing
jsonpath_filter	Yes	Yes			testing
auth_type	Yes	Editable for all integration types except 'MCP'		bearer	bearer
auth_value	Yes	Editable for all integration types except 'MCP'		masked
gateway_name	No	No		mcp-server1	mcp-server1
name	Yes	No	which would be gateway_slug + separator + name_slug (of tool) (if MCP) or name_slug (if not MCP)	mcp-server1-echo	mcp-server1-echo-tool
tags	Yes	Yes		[]	[]
custom_name	Yes	No	custom-name defaults to original_name, updates name every time custom_name is updated.	echo	echo tool
custom_name_slug	No	No	should be calculated from custom_name using sulgify function	echo	echo-tool