Make IAM API call on separate thread #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private IamToken callIamApi(Request request) { | ||
| Call call = HttpClientSingleton.getInstance().createHttpClient().newCall(request); | ||
| ResponseConverter<IamToken> converter = ResponseConverterUtils.getObject(IamToken.class); | ||
| final IamToken[] returnToken = new IamToken[1]; |
Contributor
There was a problem hiding this comment.
Does this work in Android? I think their have their own Thread management system
Contributor
Author
There was a problem hiding this comment.
Just managed to test it out and it looks like Android accepts the Java threading just fine 👌
germanattanasio
approved these changes
Mar 18, 2019
Contributor
germanattanasio
left a comment
germanattanasio
left a comment
There was a problem hiding this comment.
Looks good! and you added logging! 😱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue.
This change ensures that users don't have to make any special changes on Android going from U/P auth to IAM.