refactor: use setClient and getClient of core #599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The purpose of this PR was originally calling and returning the result of core's
invokeRequestfrom ourrequestTokenmethod, but theconvertmethod called ininvokeRequesttakes variables only from the response body. With this feature response headers which are essential toCouchDBSessionAuthenticatorcannot be reverse engineered frominvokeRequest.Although I could change
sessionAuthClientwith getter and setter methods introduced in IBM/java-sdk-core#174.PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
sessionAuthClientis set and being used from therequestTokenmethod.What is the new behavior?
The client of the class is set and being used from the
requestTokenmethod.Does this PR introduce a breaking change?
Other information