Skip to content

perf: reduce memory allocations with intelligent capacity pre-allocation #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

perf: reduce memory allocations with intelligent capacity pre-allocation #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helix-db/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,7 @@ dev = ["debug-output", "server", "bench"]
dev-instance = []
default = ["server"]
production = ["api-key","server"]

[[test]]
name = "capacity_optimization_benches"
path = "benches/capacity_optimization_benches.rs"
Comment on lines +88 to +91
Copy link
Contributor

@greptile-apps greptile-apps bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing newline at end of file - rustfmt typically adds one

Suggested change
[[test]]
name = "capacity_optimization_benches"
path = "benches/capacity_optimization_benches.rs"
[[test]]
name = "capacity_optimization_benches"
path = "benches/capacity_optimization_benches.rs"
Prompt To Fix With AI 
This is a comment left during a code review.
Path: helix-db/Cargo.toml
Line: 80:83

Comment:
**style:** Missing newline at end of file - `rustfmt` typically adds one

```suggestion
[[test]]
name = "capacity_optimization_benches"
path = "benches/capacity_optimization_benches.rs"
```

How can I resolve this? If you propose a fix, please make it concise.

3 changes: 1 addition & 2 deletions helix-db/benches/bm25_benches.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
mod tests {
use helix_db::{
debug_println,
helix_engine::bm25::bm25::{HBM25Config, BM25},
helix_engine::bm25::bm25::{BM25, HBM25Config},
utils::{id::v6_uuid, tqdm::tqdm},
};

Expand Down Expand Up @@ -155,4 +155,3 @@ mod tests {
}
}
}

Loading
Loading