Cashu bolt12 send and receive with sending to bip353 #266
+1,421
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
71
to
+79
| pub fn payment_hash(&self) -> [u8; 32] { | ||
| FromHex::from_hex(&self.payment_hash).expect("invalid payment hash") | ||
| FromHex::from_hex(self.payment_hash.as_ref().expect("missing payment hash")) | ||
| .expect("invalid payment hash") | ||
| } | ||
|
|
||
| pub fn bolt11(&self) -> Bolt11Invoice { | ||
| Bolt11Invoice::from_str(&self.bolt11).expect("invalid bolt11") | ||
| Bolt11Invoice::from_str(self.bolt11.as_ref().expect("missing bolt11")) | ||
| .expect("invalid bolt11") | ||
| } |
There was a problem hiding this comment.
should make these optional
Comment on lines
90
to
+98
| pub fn payment_hash(&self) -> [u8; 32] { | ||
| FromHex::from_hex(&self.payment_hash).expect("invalid payment hash") | ||
| FromHex::from_hex(self.payment_hash.as_ref().expect("missing payment hash")) | ||
| .expect("invalid payment hash") | ||
| } | ||
|
|
||
| pub fn bolt11(&self) -> Bolt11Invoice { | ||
| Bolt11Invoice::from_str(&self.bolt11).expect("invalid bolt11") | ||
| Bolt11Invoice::from_str(self.bolt11.as_ref().expect("missing bolt11")) | ||
| .expect("invalid bolt11") | ||
| } |
There was a problem hiding this comment.
should make these optional
| } | ||
|
|
||
| // sort by timestamp so that the most recent items are at the top |
There was a problem hiding this comment.
should keep this comment
| ReceiveBolt12 { | ||
| mint: MintIdentifier, | ||
| amount: Option<Amount>, | ||
| // NOTE: The following block was accidentally duplicated during merge. Removing to fix mismatched delimiters. |
|
|
||
| // Use CDK's BIP-353 melt flow to get a quote | ||
| let quote = client | ||
| .melt_bip353_quote(&address, cdk::Amount::from(amount_msats)) |
There was a problem hiding this comment.
this may be a problem, i am guessing this won't be over tor
| let bolt12_enabled = harbor | ||
| .active_mint | ||
| .as_ref() | ||
| .is_some_and(|a| a.mint_url().is_some()); |
There was a problem hiding this comment.
not every mint supports this, we need a flag for if they do or not
|
|
||
| let dest_input = h_input(InputArgs { | ||
| label: "Destination", | ||
| placeholder: "lnbc1...", | ||
| placeholder: "lnbc1... or lno... or ₿[email protected] or bc1...", |
There was a problem hiding this comment.
i dont really like this, can we keep the old string
| @@ -608,6 +612,60 @@ impl HarborWallet { | |||
| self.send_from_ui(UICoreMsg::SendLightning { mint, invoice }); | |||
| self.current_send_id = Some(id); | |||
| task | |||
| } else if invoice_str.starts_with("lno") { | |||
There was a problem hiding this comment.
we should be parsing this so we can tell if it needs an amount or anything. Otherwise will require us talking to the mint which can be very slow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.