Skip to content

Conversation

@StefH
Copy link
Collaborator

@StefH StefH commented Sep 12, 2025

No description provided.

@StefH StefH self-assigned this Sep 12, 2025
@StefH StefH added the bug Something isn't working label Sep 12, 2025
@StefH StefH requested a review from Copilot September 12, 2025 19:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the Humanizer Truncate helper is always accessible as "Humanizer.Truncate" by adding explicit naming to the method attribute and updating related helper registration logic.

Key changes:

  • Added explicit name to Truncate method attribute to force "Humanizer.Truncate" naming
  • Enhanced helper registration to handle dot notation in custom names
  • Added comprehensive test coverage for the Truncate helper functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
HumanizerHelpers.cs Added explicit "Humanizer.Truncate" name to the Truncate method attribute
HandlebarsHelpers.cs Enhanced helper name registration to handle dot notation replacement and code style improvements
HandlebarsHelpersOptions.cs Made Dot constant public for use in helper registration
HandlebarsWriterAttribute.cs Removed redundant using statement
HumanizerHelpersTemplateTests.cs Added comprehensive test coverage for Truncate helper with various scenarios
StringHelpersTemplateTests.cs Added test for Truncate helper without category prefix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.17%. Comparing base (3785ba7) to head (2782970).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
....Net.Helpers.Humanizer/Helpers/HumanizerHelpers.cs 0.00% 3 Missing and 2 partials ⚠️
src/Handlebars.Net.Helpers/HandlebarsHelpers.cs 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   53.25%   53.17%   -0.08%     
==========================================
  Files          51       51              
  Lines        3290     3293       +3     
  Branches      464      465       +1     
==========================================
- Hits         1752     1751       -1     
- Misses       1394     1397       +3     
- Partials      144      145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants