-
Notifications
You must be signed in to change notification settings - Fork 2k
Open
Labels
api: retailIssues related to the Retail API API.Issues related to the Retail API API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
In which file did you encounter the issue?
- retail/interactive-tutorials/test/search-with-pagination.test.js
- retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js
Did you change the file? If so, how?
Comments only
Describe the issue
72 passing (48s)
2 failing
1) Search with pagination
Search with pagination run sample
should contain next page token:
AssertionError: expected 'Search start\nThe search operation re…' to match /Next page token/
at Context.<anonymous> (interactive-tutorials/test/search-with-pagination.test.js:42:14)
at process.processImmediate (node:internal/timers:483:21)
2) Search with query expansion spec
Search with query expansion spec sample result
should contain expanded query:
AssertionError: Search response does not contain query expansion info: expected null to be an object
at Context.<anonymous> (interactive-tutorials/test/search-with-query-expansion-spec.test.js:105:15)
at process.processImmediate (node:internal/timers:483:21)
Custard CI will run all tests in a particular subfolder, so these two tests are blocking merging of a number of comment only PRs:
- fix(retail): add region tag for node.js - Update write_user_event.js #4117
- fix(retail): add region tag for nodejs - Update import products inline source #4118
- fix(retail): add region tag for nodejs - Update search with query expansion #4119
- fix(retail): add region tag for node.js - Update add fullfillment places #4120
- fix(retail): add region tag for nodejs - Update remove fulfillment places #4121
- fix(retail): add region tag for node.js - Update set inventory #4124
- fix(retail): add region tag for node.js - Update search product with boost spec #4125
- fix(retail): add region tag for node.js - Update import user events from big query #4126
- fix(retail): add region tag for node.js - Update import user events inline source #4127
- fix(retail): add region tag for node.js - Update import user events from gcs #4128
- fix(retail): add region tag for node.js - Update purge user events #4129
- fix(retail): add region tag for node.js - Update rejoin user events #4130
- fix(retail): add region tag for node.js - Update search with ordering #4131
- fix(retail): add region tag for node.js - Update search with ordering #4131
This issue serves as a reference for use when disabling these failing tests to unblock these PRs.
Metadata
Metadata
Assignees
Labels
api: retailIssues related to the Retail API API.Issues related to the Retail API API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.