refactor: options parsing #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant
suggested changes
Sep 23, 2021
Contributor
grant
left a comment
grant
left a comment
There was a problem hiding this comment.
Thanks. Looks good.
I think there are some parts where we can simplify the implementation and SLOCs while keeping the same behavior. I've added some comments.
matthewrobertson
force-pushed
the
refactor-options
branch
3 times, most recently
from
8de4965 to
e2c0f74
Compare
grant
approved these changes
Sep 23, 2021
Contributor
grant
left a comment
grant
left a comment
There was a problem hiding this comment.
Small requested changes, approved.
Comment on lines
+61
to
+66
| '--port', | ||
| '1234', | ||
| '--target=helloWorld', | ||
| '--signature-type', | ||
| 'cloudevent', | ||
| '--source=/source', |
Contributor
There was a problem hiding this comment.
nit: we're mixing using and = for arguments. Can we choose one (= seems cleaner)? Here and elsewhere.
Member
Author
There was a problem hiding this comment.
This was intentional to make sure we get test coverage for both syntax options. Alternatively I could have split this into two tests cases for --this case and --this=case. But I thought this was a bit more terse.
This commit refactors the logic for parsing CLI flags and env vars into a separate module and adds unit tests.
matthewrobertson
force-pushed
the
refactor-options
branch
from
e2c0f74 to
382642a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the logic for parsing CLI flags and env vars into a separate module and adds unit tests.