Skip to content

Conversation

@christopherlam
Copy link
Contributor

image

@christopherlam christopherlam force-pushed the price-scatter-date-xaxis branch 3 times, most recently from 43e35de to 074f64d Compare September 3, 2024 15:44
@christopherlam
Copy link
Contributor Author

Any particular opinion on this? @jralls I think the uneven date axis is a feature rather than a bug...

@christopherlam christopherlam marked this pull request as ready for review September 23, 2024 01:24
Copy link
Member

@jralls jralls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the chart is particularly useful, there are better ways to get stock price charts. It's anyway misnamed, it's a plain line chart, not a scatterplot. That's a good thing, a price scatterplot wouldn't be very useful either.

I'm all for getting rid of the different intervals, they don't even change the displayed data, just the numbers along the X axis, and those numbers are themselves pretty useless.
However using the dates of the prices to set the vertical lines makes for a strange-looking plot and it's going to get congested for plots with either a long period or showing frequent quotes. I think it would be better to break the period up into some consistent number of intervals and put date labels on each interval.

@christopherlam christopherlam requested a review from jralls March 20, 2025 13:41
@jralls
Copy link
Member

jralls commented Mar 21, 2025

@christopherlam requested a review from @jralls yesterday

Why? Nothing has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants