Skip to content

Conversation

@patrikbeno
Copy link
Contributor

@patrikbeno patrikbeno commented Apr 14, 2022

Description

Related Issue

Fixes #3071.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic arturcic requested a review from asbjornu April 14, 2022 07:00
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to see this didn't break any other tests. As such, I agree we can roll this in to v5 as a non-breaking change and consider it a bugfix. Just fix the formatting and this should be good to go!

@asbjornu asbjornu merged commit 00dcc8d into GitTools:support/5.x Apr 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2022

Thank you @patrikbeno for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New tag is ignored if the older +semver: suggests higher version

2 participants