-
Notifications
You must be signed in to change notification settings - Fork 662
Added support for NextVersion.txt in GitFlow and dynamic repositories #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| namespace GitVersion | ||
| { | ||
| using LibGit2Sharp; | ||
|
|
||
| public static class SemanticVersionExtensions | ||
| { | ||
| public static void OverrideVersionManuallyIfNeeded(this SemanticVersion version, IRepository repository) | ||
| { | ||
| var nextVersionTxtFileFinder = new NextVersionTxtFileFinder(repository.GetRepositoryDirectory()); | ||
| var manualNextVersion = nextVersionTxtFileFinder.GetNextVersion(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should only override if it is bigger. Otherwise when convention gets higher (release branch merged in for instance) this could cause a version drop There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will fix now. |
||
| if (!manualNextVersion.IsEmpty()) | ||
| { | ||
| if (manualNextVersion > version) | ||
| { | ||
| version.Major = manualNextVersion.Major; | ||
| version.Minor = manualNextVersion.Minor; | ||
| version.Patch = manualNextVersion.Patch; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition