Skip to content

Conversation

@JakeGinnivan
Copy link
Contributor

Automatically package Gem (when GitVersion_SemVer variable is available). ContinueOnError is set to true, so it will not fail the build if gems are not installed.

Also includes a NuGet.CommandLine package

@JakeGinnivan JakeGinnivan mentioned this pull request Jun 7, 2014
@JakeGinnivan
Copy link
Contributor Author

@andreasohlund because ruby is not installed on the build server, it isn't building the Gem. Thoughts on installing?

[12:28:39]Exec
[12:28:39]gem build gitversion.gemspec
[12:28:39]'gem' is not recognized as an internal or external command,
[12:28:39]operable program or batch file.
[12:28:39]Y:\BuildAgent\work\5e0d79a4e3943b17\GitVersionExe\GitVersionExe.csproj(155, 5): warning MSB3073: The command "gem build gitversion.gemspec" exited with code 9009.
[12:28:39]The previous error was converted to a warning because the task was called with ContinueOnError=true.
[12:28:39]Build continuing because "ContinueOnError" on the task "Exec" is set to "True".

@andreasohlund
Copy link
Contributor

That should be possible @gbiellem?

Sent from my iPhone

On 07 Jun 2014, at 14:57, Jake Ginnivan [email protected] wrote:

@andreasohlund because ruby is not installed on the build server, it isn't building the Gem. Thoughts on installing?

[12:28:39]Exec
[12:28:39]gem build gitversion.gemspec
[12:28:39]'gem' is not recognized as an internal or external command,
[12:28:39]operable program or batch file.
[12:28:39]Y:\BuildAgent\work\5e0d79a4e3943b17\GitVersionExe\GitVersionExe.csproj(155, 5): warning MSB3073: The command "gem build gitversion.gemspec" exited with code 9009.
[12:28:39]The previous error was converted to a warning because the task was called with ContinueOnError=true.
[12:28:39]Build continuing because "ContinueOnError" on the task "Exec" is set to "True".

Reply to this email directly or view it on GitHub.

@SimonCropp
Copy link
Contributor

Is it possible to build a gem without installing anything?

@gbiellem
Copy link

gbiellem commented Jun 8, 2014

@andreasohlund I've got no issue with installing ruby on the default build agent - Assuming that's what you want. What version ?

@JakeGinnivan
Copy link
Contributor Author

@SimonCropp not sure, I had a quick look at the format. it has nested tar's and did not look as simple as NuGet. Maybe @danielmarbach knows

@danielmarbach
Copy link
Contributor

What is the problem of installing ruby on the agents? Easiest way to get going. I don't know of any other way to issue the gem command

Am 08.06.2014 um 09:34 schrieb Jake Ginnivan [email protected]:

@SimonCropp not sure, I had a quick look at the format. it has nested tar's and did not look as simple as NuGet. Maybe @danielmarbach knows


Reply to this email directly or view it on GitHub.

@gbiellem
Copy link

gbiellem commented Jun 9, 2014

I've added Ruby to the build agent

@JakeGinnivan
Copy link
Contributor Author

@gbiellem thanks, thats working

But now we have

Invalid gemspec in [gitversion.gemspec]: Malformed version number string 1.0.0-PullRequest.190
[06:40:32]EXEC Error loading gemspec. Aborting.

According to http://guides.rubygems.org/patterns/#prerelease-gems, the format would be 1.0.0.PullRequest.190 - Or 1.0.0.PullRequest190 (if additional .'s are not allowed)

@danielmarbach any ideas on this?

@JakeGinnivan
Copy link
Contributor Author

@danielmarbach I would also like to setup automated deploy from the build server. Do we need some API key like NuGet to push the package?

@danielmarbach
Copy link
Contributor

Yes you do. You need an acc on rubygems.org. I can then add this acc as an owner of the package

Am 09.06.2014 um 20:54 schrieb Jake Ginnivan [email protected]:

@danielmarbach I would also like to setup automated deploy from the build server. Do we need some API key like NuGet to push the package?


Reply to this email directly or view it on GitHub.

@danielmarbach
Copy link
Contributor

You then just do a gem push

Am 09.06.2014 um 20:54 schrieb Jake Ginnivan [email protected]:

@danielmarbach I would also like to setup automated deploy from the build server. Do we need some API key like NuGet to push the package?


Reply to this email directly or view it on GitHub.

@JakeGinnivan
Copy link
Contributor Author

@andreasohlund did you want to create an account for the particular build server, then we can push automatically for the next release

@andreasohlund
Copy link
Contributor

I'll create an account

On Mon, Jun 9, 2014 at 11:29 PM, Jake Ginnivan [email protected]
wrote:

@andreasohlund https://github.com/andreasohlund did you want to create
an account for the particular build server, then we can push automatically
for the next release


Reply to this email directly or view it on GitHub
#190 (comment).

@andreasohlund
Copy link
Contributor

Done, handle: particular

On Tue, Jun 10, 2014 at 7:56 AM, Andreas Öhlund <
[email protected]> wrote:

I'll create an account

On Mon, Jun 9, 2014 at 11:29 PM, Jake Ginnivan [email protected]
wrote:

@andreasohlund https://github.com/andreasohlund did you want to create
an account for the particular build server, then we can push automatically
for the next release


Reply to this email directly or view it on GitHub
#190 (comment)
.

@danielmarbach
Copy link
Contributor

Need full email.

@andreasohlund
Copy link
Contributor

engineering at particular dot net

On Tue, Jun 10, 2014 at 11:52 AM, danielmarbach [email protected]
wrote:

Need full email.

From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Juni 2014 07:59
To: Particular/GitVersion
Cc: danielmarbach
Subject: Re: [GitVersion] Gem and command line packaging (#190)

Done, handle: particular

On Tue, Jun 10, 2014 at 7:56 AM, Andreas Öhlund <
mailto:[email protected] [email protected]>
wrote:

I'll create an account

On Mon, Jun 9, 2014 at 11:29 PM, Jake Ginnivan < <mailto:
[email protected]> [email protected]>
wrote:

@andreasohlund < https://github.com/andreasohlund
https://github.com/andreasohlund> did you want to create
an account for the particular build server, then we can push
automatically
for the next release


Reply to this email directly or view it on GitHub
< <
https://github.com/Particular/GitVersion/pull/190#issuecomment-45546746>
https://github.com/Particular/GitVersion/pull/190#issuecomment-45546746>
.


Reply to this email directly or view it on GitHub <
https://github.com/Particular/GitVersion/pull/190#issuecomment-45576597>
. <
https://github.com/notifications/beacon/174258__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNzk5OTExNywiZGF0YSI6eyJpZCI6MzQwOTkxNjB9fQ==--f2d9c67fe3cd9d8c6b99b114074fdd4dc5f9f5d3.gif>


Reply to this email directly or view it on GitHub
#190 (comment).

@danielmarbach
Copy link
Contributor

Owner added. Sorry for the delay

https://rubygems.org/gems/gitversion

also done for old package gitflowversion

@andreasohlund
Copy link
Contributor

What's the next step?

On Tue, Jun 10, 2014 at 11:39 PM, danielmarbach [email protected]
wrote:

Owner added. Sorry for the delay

https://rubygems.org/gems/gitversion

also done for old package gitflowversion

From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Juni 2014 12:04
To: Particular/GitVersion
Cc: danielmarbach
Subject: Re: [GitVersion] Gem and command line packaging (#190)

engineering at particular dot net

On Tue, Jun 10, 2014 at 11:52 AM, danielmarbach < <mailto:
[email protected]> [email protected]>
wrote:

Need full email.

From: Andreas Öhlund [ mailto:[email protected] mailto:
[email protected]]
Sent: Dienstag, 10. Juni 2014 07:59
To: Particular/GitVersion
Cc: danielmarbach
Subject: Re: [GitVersion] Gem and command line packaging (#190)

Done, handle: particular

On Tue, Jun 10, 2014 at 7:56 AM, Andreas Öhlund <
< mailto:[email protected] mailto:
[email protected]> mailto:[email protected]
[email protected]>
wrote:

I'll create an account

On Mon, Jun 9, 2014 at 11:29 PM, Jake Ginnivan < <mailto:
mailto:[email protected] [email protected]> <mailto:
[email protected]> [email protected]>
wrote:

@andreasohlund < < https://github.com/andreasohlund
https://github.com/andreasohlund>
https://github.com/andreasohlund https://github.com/andreasohlund>
did you want to create
an account for the particular build server, then we can push
automatically
for the next release


Reply to this email directly or view it on GitHub
< <
#190 (comment)
https://github.com/Particular/GitVersion/pull/190#issuecomment-45546746>
#190 (comment)
https://github.com/Particular/GitVersion/pull/190#issuecomment-45546746>
.


Reply to this email directly or view it on GitHub <
#190 (comment)
https://github.com/Particular/GitVersion/pull/190#issuecomment-45576597>
. <
<
https://github.com/notifications/beacon/174258__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNzk5OTExNywiZGF0YSI6eyJpZCI6MzQwOTkxNjB9fQ==--f2d9c67fe3cd9d8c6b99b114074fdd4dc5f9f5d3.gif>

https://github.com/notifications/beacon/174258__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNzk5OTExNywiZGF0YSI6eyJpZCI6MzQwOTkxNjB9fQ==--f2d9c67fe3cd9d8c6b99b114074fdd4dc5f9f5d3.gif>


Reply to this email directly or view it on GitHub
< <
https://github.com/Particular/GitVersion/pull/190#issuecomment-45594413>
https://github.com/Particular/GitVersion/pull/190#issuecomment-45594413>.


Reply to this email directly or view it on GitHub <
https://github.com/Particular/GitVersion/pull/190#issuecomment-45595317>
. <
https://github.com/notifications/beacon/174258__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxODAxMzgxNSwiZGF0YSI6eyJpZCI6MzQwOTkxNjB9fQ==--75f14f66358cf0ceaff2ce5de9215c4618872fd6.gif>


Reply to this email directly or view it on GitHub
#190 (comment).

@danielmarbach
Copy link
Contributor

Replace the version string, use gem build gitversion-*.gemspec when you want to push just issue gem push in the folder where the built gemfile is stored

@JakeGinnivan
Copy link
Contributor Author

I have already done the version string replace.

The outstanding question for me is how to fix

Invalid gemspec in [gitversion.gemspec]: Malformed version number string 1.0.0-PullRequest.190
[06:40:32]EXEC Error loading gemspec. Aborting.

Do we need a new variable which changes it to 1.0.0.PullRequest190 ?

@JakeGinnivan
Copy link
Contributor Author

And then do we have to Pad?

@danielmarbach
Copy link
Contributor

I think so. But I'm no gemspec expert

Am 11.06.2014 um 10:07 schrieb Jake Ginnivan [email protected]:

And then do we have to Pad?


Reply to this email directly or view it on GitHub.

@JakeGinnivan
Copy link
Contributor Author

image

How does this look to everyone. Are we ok with the fact the chocolatey package is being renamed? I kinda think maybe Chocolatey should stay the same and we rename NuGet to GitVersion.Library or something?

@andreasohlund
Copy link
Contributor

@JakeGinnivan this one seems ready to go. Rebase?

@JakeGinnivan
Copy link
Contributor Author

Will try rebase this morning before I head off to Download Festival :)

@JakeGinnivan
Copy link
Contributor Author

Rebased, im heading out now. So if build fails it will be tomorrow when I get it sorted

@andreasohlund
Copy link
Contributor

Failed :)

On Fri, Jun 13, 2014 at 12:27 PM, Jake Ginnivan [email protected]
wrote:

Rebased, im heading out now. So if build fails it will be tomorrow when I
get it sorted


Reply to this email directly or view it on GitHub
#190 (comment).

@JakeGinnivan
Copy link
Contributor Author

@agross
Copy link
Contributor

agross commented Jun 14, 2014

Looks good to me. Before releasing, please consider #193!

JakeGinnivan added a commit that referenced this pull request Jun 19, 2014
@JakeGinnivan JakeGinnivan merged commit 22aa5d3 into GitTools:master Jun 19, 2014
@JakeGinnivan JakeGinnivan deleted the GemAndCommandLinePackaging branch June 19, 2014 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants