Skip to content

Add MajorMinor to AssemblyVersioningScheme #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2014
Merged

Add MajorMinor to AssemblyVersioningScheme #180

merged 1 commit into from
May 22, 2014

Conversation

@nulltoken
Copy link
Contributor

@nulltoken nulltoken commented May 21, 2014

...along with some tests.

cf #147

@nulltoken nulltoken added the bug label May 21, 2014
@nulltoken nulltoken self-assigned this May 21, 2014
@nulltoken
Copy link
Contributor Author

nulltoken commented May 21, 2014

@andreasohlund Done!

@SimonCropp
Copy link
Contributor

SimonCropp commented May 21, 2014

@nulltoken looks good to me. want me to merge and release?

@andreasohlund
Copy link
Contributor

andreasohlund commented May 22, 2014

This can go into 1.0.0 since we havent released yet

Sent from my iPhone

On 21 May 2014, at 21:11, nulltoken [email protected] wrote:

@andreasohlund Done!

—
Reply to this email directly or view it on GitHub.

@nulltoken nulltoken merged commit 0c11af2 into master May 22, 2014
@nulltoken nulltoken deleted the hotfix-1.0.1 branch May 22, 2014 05:53
@nulltoken
Copy link
Contributor Author

nulltoken commented May 22, 2014

@SimonCropp Thanks for the review!

This can go into 1.0.0 since we havent released yet

@andreasohlund I've fast-forward merged it.

@andreasohlund
Copy link
Contributor

andreasohlund commented May 22, 2014

Sweet!

On Thu, May 22, 2014 at 7:58 AM, nulltoken [email protected] wrote:

@SimonCropp https://github.com/SimonCropp Thanks for the review!

This can go into 1.0.0 since we havent released yet

@andreasohlund https://github.com/andreasohlund I've fast-forward
merged it.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/180#issuecomment-43851281
.

@nulltoken nulltoken removed their assignment Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nulltoken @SimonCropp @andreasohlund