Proposal add project integrations slack / jira #759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqmos
changed the title
added 2 commits
June 12, 2023 17:17
Contributor
|
@coqmos I just found this and wanted to start on my own. Thanks for your work. If I look at the GitLab Integrations API (https://docs.gitlab.com/ee/api/integrations.html) I think that your approach will blow up the projects.php file. What do you think about an approach where you have an integrations() function in projects to get the overview, but have an extra Integrations class where we could handle the different integrations? |
Contributor
Author
|
@pkolmann you are right it would I like your suggestion and will try to update the merge request later on :) |
Contributor
|
@coqmos since I already had most if it ready, I took the liberty and added jira to my changes and did another pull request. Please take a look and help me improve the code. |
Member
|
Closing in favour of #760. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.