fix(models): make optional variables optional

[SofienM]

Some variables set as optional were not optional. This was catched on an error using ggshield.

ggshield scan path sample.xml


Traceback (most recent call last):
  File "/home/sofiengg/.local/lib/python3.8/site-packages/ggshield/dev_scan.py", line 169, in path_cmd
    results = files.scan(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/ggshield/scan/scannable.py", line 139, in scan
    scan = future.result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 437, in result
    return self.__get_result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/pygitguardian/client.py", line 291, in multi_content_scan
    obj = MultiScanResult.SCHEMA.load(dict(scan_results=resp.json()))
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 714, in load
    return self._do_load(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 848, in _do_load
    result = self._deserialize(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 656, in _deserialize
    value = self._call_and_store(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 488, in _call_and_store
    value = getter_func(data)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 653, in <lambda>
    getter = lambda val: field_obj.deserialize(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 344, in deserialize
    output = self._deserialize(value, attr, data, **kwargs)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 708, in _deserialize
    result.append(self.inner.deserialize(each, **kwargs))
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 344, in deserialize
    output = self._deserialize(value, attr, data, **kwargs)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 591, in _deserialize
    return self._load(value, data, partial=partial)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 574, in _load
    valid_data = self.schema.load(value, unknown=self.unknown, partial=partial)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 714, in load
    return self._do_load(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 848, in _do_load
    result = self._deserialize(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 656, in _deserialize
    value = self._call_and_store(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 488, in _call_and_store
    value = getter_func(data)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 653, in <lambda>
    getter = lambda val: field_obj.deserialize(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 344, in deserialize
    output = self._deserialize(value, attr, data, **kwargs)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 708, in _deserialize
    result.append(self.inner.deserialize(each, **kwargs))
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 344, in deserialize
    output = self._deserialize(value, attr, data, **kwargs)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 591, in _deserialize
    return self._load(value, data, partial=partial)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/fields.py", line 574, in _load
    valid_data = self.schema.load(value, unknown=self.unknown, partial=partial)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 714, in load
    return self._do_load(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 884, in _do_load
    result = self._invoke_load_processors(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 1082, in _invoke_load_processors
    data = self._invoke_processors(
  File "/home/sofiengg/.local/lib/python3.8/site-packages/marshmallow/schema.py", line 1214, in _invoke_processors
    data = processor(data, many=many, **kwargs)
  File "/home/sofiengg/.local/lib/python3.8/site-packages/pygitguardian/models.py", line 202, in make_policy_break
    return PolicyBreak(**data)

[codecov-commenter]

Codecov Report

Merging #20 (85be435) into master (e8061b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files           4        4           
  Lines         300      300           
=======================================
  Hits          299      299           
  Misses          1        1           

Flag	Coverage Δ
unittests	99.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pygitguardian/models.py	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8061b9...85be435. Read the comment docs.

[Jguer]

LGTM