Handle liveness/readiness probes with /api/health

[wied03]

No description provided.

[johnjeffers]

This doesn't allow for arbitrary, non-semver tags. It's an edge case, but if someone uses a custom image tag that isn't semver, the chart will fail.

helm template .
--set database.host=test
--set database.user=test
--set database.password=test
--set search.host=elastic
--set image.tag=arbitrary-1.59.0
-s templates/deployment.yaml

Error: template: fusionauth/templates/deployment.yaml:85:56: executing "fusionauth/templates/deployment.yaml" at <include "fusionauth.probePath" (dict "Values" .Values "probeName" "liveness")>: error calling include: template: fusionauth/templates/_helpers.tpl:126:7: executing "fusionauth.probePath" at <semverCompare ">=1.52.0" .Values.image.tag>: error calling semverCompare: Invalid Semantic Version


I'll see if there's another way of handling this that would allow for non-semver tags -- unless you get to it first :)

[wied03]

This doesn't allow for arbitrary, non-semver tags. It's an edge case, but if someone uses a custom image tag that isn't semver, the chart will fail.

helm template . --set database.host=test --set database.user=test --set database.password=test --set search.host=elastic --set image.tag=arbitrary-1.59.0 -s templates/deployment.yaml

Error: template: fusionauth/templates/deployment.yaml:85:56: executing "fusionauth/templates/deployment.yaml" at <include "fusionauth.probePath" (dict "Values" .Values "probeName" "liveness")>: error calling include: template: fusionauth/templates/_helpers.tpl:126:7: executing "fusionauth.probePath" at <semverCompare ">=1.52.0" .Values.image.tag>: error calling semverCompare: Invalid Semantic Version

I'll see if there's another way of handling this that would allow for non-semver tags -- unless you get to it first :)

So the use case is someone takes one of our images, completely changes the version to a non semver version, and wants to use our Helm chart, without overriding the startup probe themselves? To me that seems very edge.